[jira] [Commented] (CAMEL-15403) camel-xmlsecurity - Some unit tests fails with Oracle JDK8 261

["Colm O hEigeartaigh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-15403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418487#comment-17418487 ] 

Colm O hEigeartaigh commented on CAMEL-15403:
---------------------------------------------

[~ffang] Looks like this fix causes other JDK vendors to fail. Right now the tests fail for me with:

openjdk version "1.8.0_265"
OpenJDK Runtime Environment (Zulu 8.48.0.53-CA-linux64) (build 1.8.0_265-b11)

 

> camel-xmlsecurity - Some unit tests fails with Oracle JDK8 261
> --------------------------------------------------------------
>
>                 Key: CAMEL-15403
>                 URL: https://issues.apache.org/jira/browse/CAMEL-15403
>             Project: Camel
>          Issue Type: Test
>          Components: camel-xmlsecurity
>    Affects Versions: 3.4.2
>            Reporter: Freeman Yue Fang
>            Assignee: Freeman Yue Fang
>            Priority: Major
>             Fix For: 3.5.0, 3.4.4
>
>
> It's caused by a newline "\n" isn't expected in the test payload for JDK 1.8_261.
> I noticed that we've already had code like
> {code}
> if (TestSupport.getJavaMajorVersion() >= 9) {
>             includeNewLine = false;
>         }
> {code}
> to determine need this newline or not. And I believe the lastest JDK8(Oracle JDK8 261) surely take the same logic as JDK9+ now.
> We need also check the 1.8 minor version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)