[GitHub] [iceberg] rdblue commented on a change in pull request #1317: Add specId to DataFile

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1317:
URL: https://github.com/apache/iceberg/pull/1317#discussion_r705775407



##########
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##########
@@ -1129,8 +1133,12 @@ public void testManifestEntryFieldIdsForChangedPartitionSpecForV1Table() {
     V2Assert.assertEquals("Last sequence number should be 1", 1, readMetadata().lastSequenceNumber());
     V1Assert.assertEquals("Table should end with last-sequence-number 0", 0, readMetadata().lastSequenceNumber());
 
+    // create a new with the table's current spec
     DataFile newFile = DataFiles.builder(table.spec())
-        .copy(FILE_B)
+        .withPath("/path/to/data-x.parquet")
+        .withFileSizeInBytes(10)
+        .withPartitionPath("id_bucket=1/data_bucket=1")
+        .withRecordCount(1)

Review comment:
       Why did these tests change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org