You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/12/01 14:46:38 UTC
Review Request 64247: Fixed a flaky test case in reservation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Bugs: MESOS-8289
https://issues.apache.org/jira/browse/MESOS-8289
Repository: mesos
Description
-------
ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master failover,
the re-registered framework could receive an offer before the
re-registered sends a 'UPDATE_SLAVE' message. On receiving this message,
the master would rescind the offer and send out a new one. The test
expected a single offer to be send. It has been changed to accept the
first offer and ignore subsequent ones.
Also, the test case has been updated to run with paused clocks.
Diffs
-----
src/tests/reservation_tests.cpp f29e9bbb3d3b4dbaf21cd04f5efcf0df7cc34459
Diff: https://reviews.apache.org/r/64247/diff/1/
Testing
-------
src/mesos-tests
`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
Thanks,
Jan Schlicht
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/#review192497
-----------------------------------------------------------
FAIL: Mesos libprocess-tests failed to build
Reviews applied: `['64247']`
Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64247
Relevant logs:
- [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64247/logs/libprocess-tests-build-cmake-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
"C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
96 Warning(s)
6 Error(s)
Time Elapsed 00:04:21.92
```
- [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64247/logs/libprocess-tests-CMakeOutput.log):
```
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_95cc7.dir\Debug\cmTC_95cc7.tlog\".
InitializeBuildStatus:
Creating "cmTC_95cc7.dir\Debug\cmTC_95cc7.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_95cc7.dir\Debug\" /Fd"cmTC_95cc7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_95cc7.dir\Debug\" /Fd"cmTC_95cc7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_95cc7.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_95cc7.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_95cc7.lib" /MACHINE:X64 /machine:x64 cmTC_95cc7.dir\Debug\src.obj
cmTC_95cc7.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_95cc7.exe
cmTC_95cc7.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_95cc7.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_95cc7.dir\Debug\cmTC_95cc7.tlog\unsuccessfulbuild".
Touching "cmTC_95cc7.dir\Debug\cmTC_95cc7.tlog\cmTC_95cc7.lastbuildstate".
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_95cc7.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.75
Source file was:
int main() { return 0; }
```
- [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64247/logs/libprocess-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_21745.dir\Debug\".
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_21745.dir\Debug\cmTC_21745.tlog\".
InitializeBuildStatus:
Creating "cmTC_21745.dir\Debug\cmTC_21745.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_21745.dir\Debug\" /Fd"cmTC_21745.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_21745.dir\Debug\" /Fd"cmTC_21745.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_21745.vcxproj]
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_21745.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_21745.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_21745.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.10
```
- Mesos Reviewbot Windows
On Dec. 1, 2017, 2:46 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64247/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 2:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Bugs: MESOS-8289
> https://issues.apache.org/jira/browse/MESOS-8289
>
>
> Repository: mesos
>
>
> Description
> -------
>
> ReservationTest.MasterFailover could fail when parameterized with
> the 'RESOURCE_PROVIDER' capability. After the simulated master failover,
> the re-registered framework could receive an offer before the
> re-registered sends a 'UPDATE_SLAVE' message. On receiving this message,
> the master would rescind the offer and send out a new one. The test
> expected a single offer to be send. It has been changed to accept the
> first offer and ignore subsequent ones.
>
> Also, the test case has been updated to run with paused clocks.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp f29e9bbb3d3b4dbaf21cd04f5efcf0df7cc34459
>
>
> Diff: https://reviews.apache.org/r/64247/diff/1/
>
>
> Testing
> -------
>
> src/mesos-tests
>
> `src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/#review192975
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/reservation_tests.cpp
Line 942 (original)
<https://reviews.apache.org/r/64247/#comment271412>
Let's resume here to finish the test with the running clock.
- Alexander Rukletsov
On Dec. 6, 2017, 10:46 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64247/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 10:46 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Bugs: MESOS-8289
> https://issues.apache.org/jira/browse/MESOS-8289
>
>
> Repository: mesos
>
>
> Description
> -------
>
> ReservationTest.MasterFailover could fail when parameterized with
> the 'RESOURCE_PROVIDER' capability. After the simulated master
> failover, the re-registered framework could receive an offer before
> the re-registered agent sends a 'UPDATE_SLAVE' message. On receiving
> this message, the master would rescind the offer and send out a new
> one. The test expected a single offer to be send. It has been changed
> to accept the first offer and ignore subsequent ones.
>
> Also, the test case has been updated to run with paused clocks.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 7f1bb398c33b3b8cad371b49bdc4bc2454f6440d
>
>
> Diff: https://reviews.apache.org/r/64247/diff/2/
>
>
> Testing
> -------
>
> src/mesos-tests
>
> `src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 10:46 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Bugs: MESOS-8289
https://issues.apache.org/jira/browse/MESOS-8289
Repository: mesos
Description (updated)
-------
ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master
failover, the re-registered framework could receive an offer before
the re-registered agent sends a 'UPDATE_SLAVE' message. On receiving
this message, the master would rescind the offer and send out a new
one. The test expected a single offer to be send. It has been changed
to accept the first offer and ignore subsequent ones.
Also, the test case has been updated to run with paused clocks.
Diffs
-----
src/tests/reservation_tests.cpp 7f1bb398c33b3b8cad371b49bdc4bc2454f6440d
Diff: https://reviews.apache.org/r/64247/diff/2/
Testing
-------
src/mesos-tests
`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
Thanks,
Jan Schlicht
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 2:05 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Changes
-------
Rebased, removed superfluous code.
Bugs: MESOS-8289
https://issues.apache.org/jira/browse/MESOS-8289
Repository: mesos
Description (updated)
-------
ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master failover,
the re-registered framework could receive an offer before the
re-registered agent sends a 'UPDATE_SLAVE' message. On receiving this
message, the master would rescind the offer and send out a new one.
The test expected a single offer to be send. It has been changed to
accept the first offer and ignore subsequent ones.
Also, the test case has been updated to run with paused clocks.
Diffs (updated)
-----
src/tests/reservation_tests.cpp 7f1bb398c33b3b8cad371b49bdc4bc2454f6440d
Diff: https://reviews.apache.org/r/64247/diff/2/
Changes: https://reviews.apache.org/r/64247/diff/1-2/
Testing
-------
src/mesos-tests
`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
Thanks,
Jan Schlicht
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 11:17 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Bugs: MESOS-8289
https://issues.apache.org/jira/browse/MESOS-8289
Repository: mesos
Description (updated)
-------
ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master
failover, the re-registered framework could receive an offer before
the re-registered agent sends a 'UPDATE_SLAVE' message. On receiving
this message, the master would rescind the offer and send out a new
one. The test expected a single offer to be send. It has been changed
to accept the first offer and ignore subsequent ones.
Also, the test case has been updated to run with paused clocks.
Diffs
-----
src/tests/reservation_tests.cpp f29e9bbb3d3b4dbaf21cd04f5efcf0df7cc34459
Diff: https://reviews.apache.org/r/64247/diff/1/
Testing
-------
src/mesos-tests
`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
Thanks,
Jan Schlicht
Re: Review Request 64247: Fixed a flaky test case in reservation
tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 12:15 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Bugs: MESOS-8289
https://issues.apache.org/jira/browse/MESOS-8289
Repository: mesos
Description (updated)
-------
ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master failover,
the re-registered framework could receive an offer before the
re-registered agent sends a 'UPDATE_SLAVE' message. On receiving this message,
the master would rescind the offer and send out a new one. The test
expected a single offer to be send. It has been changed to accept the
first offer and ignore subsequent ones.
Also, the test case has been updated to run with paused clocks.
Diffs
-----
src/tests/reservation_tests.cpp f29e9bbb3d3b4dbaf21cd04f5efcf0df7cc34459
Diff: https://reviews.apache.org/r/64247/diff/1/
Testing
-------
src/mesos-tests
`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine)
Thanks,
Jan Schlicht