You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/14 14:20:56 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #6846: support mysql database create, alter and drop statement
strongduanmu opened a new pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846
Ref #6498 .
Changes proposed in this pull request:
- support mysql database create, alter and drop statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-675416369
## Pull Request Test Coverage Report for [Build 13775](https://coveralls.io/builds/32762350)
* **3** of **5** **(60.0%)** changed or added relevant lines in **3** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.0005%**) to **57.908%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/impl/MySQLDDLVisitor.java](https://coveralls.io/builds/32762350/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2Fimpl%2FMySQLDDLVisitor.java#L129) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/AlterDatabaseStatement.java](https://coveralls.io/builds/32762350/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FAlterDatabaseStatement.java#L23) | 0 | 1 | 0.0%
<!-- | **Total:** | **3** | **5** | **60.0%** | -->
| Totals | [](https://coveralls.io/builds/32762350) |
| :-- | --: |
| Change from base [Build 13774](https://coveralls.io/builds/32757874): | 0.0005% |
| Covered Lines: | 13090 |
| Relevant Lines: | 22605 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu edited a comment on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
strongduanmu edited a comment on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688598286
> hello, I have a question
> shardingsphere version: 4.0.0-RC3
> `
> alter table w_test_f_0
> add column test1 varchar(10) null default null comment 'test';
> // This statement can be executed normally
>
> alter table w_test_f_0
> add column test1 amount null default null comment 'test';
> // This statement throw NPE
> `
> Can this merge solve this problem?
@meiyouxiaojianpan Hi, can you provide the sharding configuration and the schema of the table `w_test_f_0`? I will check it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] meiyouxiaojianpan commented on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
meiyouxiaojianpan commented on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688590709
hello, I have a question
shardingsphere version: 4.0.0-RC3
`
alter table w_test_f_0
add column test1 varchar(10) null default null comment 'test';
// This statement can be executed normally
alter table w_test_f_0
add column test1 amount null default null comment 'test';
// This statement throw NPE
`
Can this merge solve this problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688598286
> hello, I have a question
> shardingsphere version: 4.0.0-RC3
> `
> alter table w_test_f_0
> add column test1 varchar(10) null default null comment 'test';
> // This statement can be executed normally
>
> alter table w_test_f_0
> add column test1 amount null default null comment 'test';
> // This statement throw NPE
> `
> Can this merge solve this problem?
@meiyouxiaojianpan Hi, can you provide the sharding configuration and the schema of the table `w_test_f_0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688895208
> My configuration only configures the mysql view, example: `w_test_v_0`
> `w_test_f_0` is not configured but processed by shardingsphere method `org.apache.shardingsphere.core.parse.core.extractor.impl.ddl.column.ColumnDefinitionExtractor#extract`
> 
> getChild(0) is null
> Thank you for answering my question
@meiyouxiaojianpan I am very sorry that I can not get your point. Can you provide the sharding configuration and the structure of the `w_test_f_0` table —— like `create table w_test_f_0 ...` ? I need a case to reproduce the bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] meiyouxiaojianpan commented on pull request #6846: support mysql database create, alter and drop statement
Posted by GitBox <gi...@apache.org>.
meiyouxiaojianpan commented on pull request #6846:
URL: https://github.com/apache/shardingsphere/pull/6846#issuecomment-688672941
My configuration only configures the mysql view, example: `w_test_v_0`
`w_test_f_0` is not configured but processed by shardingsphere method `org.apache.shardingsphere.core.parse.core.extractor.impl.ddl.column.ColumnDefinitionExtractor#extract`
getChild(0) is null
Thank you for answering my question
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org