You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/01 16:18:00 UTC
[jira] [Work logged] (HIVE-25492) Major query-based compaction is skipped if partition is empty
[ https://issues.apache.org/jira/browse/HIVE-25492?focusedWorklogId=751653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751653 ]
ASF GitHub Bot logged work on HIVE-25492:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/22 16:17
Start Date: 01/Apr/22 16:17
Worklog Time Spent: 10m
Work Description: asinkovits commented on a change in pull request #3157:
URL: https://github.com/apache/hive/pull/3157#discussion_r840737839
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -28,16 +28,7 @@
import java.io.Serializable;
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
+import java.util.*;
Review comment:
Fied.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -28,16 +28,7 @@
import java.io.Serializable;
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
+import java.util.*;
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 751653)
Time Spent: 1h 20m (was: 1h 10m)
> Major query-based compaction is skipped if partition is empty
> -------------------------------------------------------------
>
> Key: HIVE-25492
> URL: https://issues.apache.org/jira/browse/HIVE-25492
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently if the result of query-based compaction is an empty base, delta, or delete delta, the empty directory is deleted.
> This is because of minor compaction – if there are only deltas to compact, then no compacted delete delta should be created (only a compacted delta). In the same way, if there are only delete deltas to compact, then no compacted delta should be created (only a compacted delete delta).
> There is an issue with major compaction. If all the data in the partition has been deleted, then we should get an empty base directory after compaction. Instead, the empty base directory is deleted because it's empty and compaction claims to succeed but we end up with the same deltas/delete deltas we started with – basically compaction does not run.
> Where to start? MajorQueryCompactor#commitCompaction
--
This message was sent by Atlassian Jira
(v8.20.1#820001)