[jira] [Created] (HDFS-5588) Incorrect values of trash configuration and trash emptier state in namenode log

["Adam Kawa (JIRA)" <ji...@apache.org>]

Adam Kawa created HDFS-5588:
-------------------------------

             Summary: Incorrect values of trash configuration and trash emptier state in namenode log
                 Key: HDFS-5588
                 URL: https://issues.apache.org/jira/browse/HDFS-5588
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: hdfs-client, namenode
    Affects Versions: 2.2.0
            Reporter: Adam Kawa


Values of trash configuration and trash emptier state in namenode log are displayed in milliseconds (but it should be seconds). This is very confusing because it makes you feel that Trash does not remove data or the meaning of configuration settings changed.

{code}
// org.apache.hadoop.fs.TrashPolicyDefault
  @Override
  public void initialize(Configuration conf, FileSystem fs, Path home) {
    ...
    this.deletionInterval = (long)(conf.getFloat(
        FS_TRASH_INTERVAL_KEY, FS_TRASH_INTERVAL_DEFAULT)
        * MSECS_PER_MINUTE);
    this.emptierInterval = (long)(conf.getFloat(
        FS_TRASH_CHECKPOINT_INTERVAL_KEY, FS_TRASH_CHECKPOINT_INTERVAL_DEFAULT)
        * MSECS_PER_MINUTE);
    LOG.info("Namenode trash configuration: Deletion interval = " +
             this.deletionInterval + " minutes, Emptier interval = " +
             this.emptierInterval + " minutes.");
   }
{code}

this.deletionInterval and this.emptierInterval are in miliseconds, but the LOG.info tells that they are in minutes.



--
This message was sent by Atlassian JIRA
(v6.1#6144)