You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/04/03 16:44:10 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #4468: Python: reorganize expressions module structure

rdblue commented on a change in pull request #4468:
URL: https://github.com/apache/iceberg/pull/4468#discussion_r841248653



##########
File path: python/tests/expressions/test_operations.py
##########
@@ -17,26 +17,26 @@
 
 import pytest
 
-from iceberg import expressions
+from iceberg.expressions import operations

Review comment:
       Shouldn't `operations` go into `base.py` and then get exposed in `__init__.py`? I would probably leave the tests unchanged and use `expressions.Operation.*`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org