[jira] [Commented] (CAMEL-8001) SmppUtils.isGsm0338Encodeable() called with arbitrary data

["Christian Müller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-8001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205352#comment-14205352 ] 

Christian Müller commented on CAMEL-8001:
-----------------------------------------

This patch cannot be merged into the Camel master branch.
Daniel, could you please check and reattach the corrected patch!?

> SmppUtils.isGsm0338Encodeable() called with arbitrary data
> ----------------------------------------------------------
>
>                 Key: CAMEL-8001
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8001
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>    Affects Versions: 2.12.2
>         Environment: n/a
>            Reporter: Daniel Pocock
>              Labels: patch
>         Attachments: determineAlphabet_fix.patch
>
>
> The method SmppUtils.isGsm0338Encodeable(byte[]) expects the input data to be Latin1 encoded (or a subset of Latin1, such as ASCII)
> The method SmppSmCommand.determineAlphabet(Message) prepares an argument by calling String.getBytes(charset) without checking the charset is Latin1 or compatible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)