You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/11/09 13:17:56 UTC

Review Request 63699: RANGER-1882 - Compilation error in kms module with Hadoop 2.8.x

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63699/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1882
    https://issues.apache.org/jira/browse/RANGER-1882


Repository: ranger


Description
-------

There is a compilation failure in the KMS module when compiled with Hadoop 2.8.x. The fix is just to use a constant String which works with both Hadoop 2.7.x, 2.8.x.


Diffs
-----

  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ada9a56f 


Diff: https://reviews.apache.org/r/63699/diff/1/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 63699: RANGER-1882 - Compilation error in kms module with Hadoop 2.8.x

Posted by Colm O hEigeartaigh <co...@apache.org>.

> On Nov. 9, 2017, 6:22 p.m., Alejandro Fernandez wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
> > Line 74 (original), 73 (patched)
> > <https://reviews.apache.org/r/63699/diff/1/?file=1886105#file1886105line74>
> >
> >     Which other versions of Hadoop are supported?

Right now, only Hadoop 2.7.x. With this change both Hadoop 2.8.x and 2.7.x will be supported.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63699/#review190623
-----------------------------------------------------------


On Nov. 9, 2017, 1:17 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63699/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 1:17 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1882
>     https://issues.apache.org/jira/browse/RANGER-1882
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> There is a compilation failure in the KMS module when compiled with Hadoop 2.8.x. The fix is just to use a constant String which works with both Hadoop 2.7.x, 2.8.x.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ada9a56f 
> 
> 
> Diff: https://reviews.apache.org/r/63699/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 63699: RANGER-1882 - Compilation error in kms module with Hadoop 2.8.x

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63699/#review190623
-----------------------------------------------------------




kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java
Line 74 (original), 73 (patched)
<https://reviews.apache.org/r/63699/#comment268127>

    Which other versions of Hadoop are supported?


- Alejandro Fernandez


On Nov. 9, 2017, 1:17 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63699/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 1:17 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1882
>     https://issues.apache.org/jira/browse/RANGER-1882
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> There is a compilation failure in the KMS module when compiled with Hadoop 2.8.x. The fix is just to use a constant String which works with both Hadoop 2.7.x, 2.8.x.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ada9a56f 
> 
> 
> Diff: https://reviews.apache.org/r/63699/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>