You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "Reamer (via GitHub)" <gi...@apache.org> on 2024/03/04 15:18:17 UTC
[PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Reamer opened a new pull request, #4725:
URL: https://github.com/apache/zeppelin/pull/4725
### What is this PR for?
This is a follow-up from https://github.com/apache/zeppelin/pull/4699
The Livy tests are currently not working, so I have deactivated the tests.
### What type of PR is it?
- Improvement
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5986
### How should this be tested?
* CI
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4725:
URL: https://github.com/apache/zeppelin/pull/4725#issuecomment-1979954668
Agreed. Adding @Disable first and let's talk about the issue in another thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4725:
URL: https://github.com/apache/zeppelin/pull/4725#issuecomment-1978195434
The changes in upgrading Maven plugins and fixing Spark on YARN integration tests make sense to me, while for Livy's part, we can minimal the change by simply adding one `@Disable` annotation on the test class to skip it temporarily and then fix or drop it later with community-level consensus.
The selenium test looks like fails constantly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4725:
URL: https://github.com/apache/zeppelin/pull/4725#discussion_r1512118527
##########
zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/SparkIntegrationTest.java:
##########
@@ -389,4 +393,20 @@ private String getPythonExec() throws IOException, InterruptedException {
}
return IOUtils.toString(process.getInputStream(), StandardCharsets.UTF_8).trim();
}
+
+ private String getRScriptExec() throws IOException, InterruptedException {
+ Process process = Runtime.getRuntime().exec(new String[]{"which", "Rscript"});
+ if (process.waitFor() != 0) {
+ throw new RuntimeException("Fail to run command: which Rscript.");
+ }
+ return IOUtils.toString(process.getInputStream(), StandardCharsets.UTF_8).trim();
+ }
+
+ private String getRExec() throws IOException, InterruptedException {
+ Process process = Runtime.getRuntime().exec(new String[]{"which", "R"});
+ if (process.waitFor() != 0) {
+ throw new RuntimeException("Fail to run command: which Rscript.");
Review Comment:
```suggestion
throw new RuntimeException("Fail to run command: which R.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4725:
URL: https://github.com/apache/zeppelin/pull/4725#issuecomment-2002135372
Closed in favour of #4734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4725:
URL: https://github.com/apache/zeppelin/pull/4725#issuecomment-1983555202
> We can minimize the change by simply adding one @Disable annotation on the test class to skip it temporarily
done
> The selenium test looks like fails constantly?
I think it is also due to the new Surefire version. But I don't know why. At the same time, I'm working on simplifying the test setup with PR #4726 start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-5986] Update surefire and failsafe [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer closed pull request #4725: [ZEPPELIN-5986] Update surefire and failsafe
URL: https://github.com/apache/zeppelin/pull/4725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org