You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/02/14 21:03:11 UTC

[jira] [Commented] (HADOOP-11596) Allow smart-apply-patch.sh to add new files in binary git patches

    [ https://issues.apache.org/jira/browse/HADOOP-11596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321674#comment-14321674 ] 

Hadoop QA commented on HADOOP-11596:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12698920/HADOOP-11596.02.patch
  against trunk revision ef950ea.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5700//console

This message is automatically generated.

> Allow smart-apply-patch.sh to add new files in binary git patches
> -----------------------------------------------------------------
>
>                 Key: HADOOP-11596
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11596
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HADOOP-11596.01.patch, HADOOP-11596.02.patch
>
>
> When a new file is added, the source is /dev/null (rather than the root of the tree (which would mean a a/b prefix)) Allow for this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)