Re: DOCX: merged comments

[Pavel Janík <Pa...@Janik.cz>]

On Nov 30, 2012, at 9:22 AM, Pavel Janík wrote:

> So yes, the patch is influenced by similar LO change and Apache OpenOffice project has to receive original author's ack. Accorging to LibreOffice' VCS, it is Cedric. I'll ask him for acknowledgement.

Cedric declined, so if anyone is interested to recreate the change from scratch, go for it. It is very simple one. I won't do it myself to prevent legal issues.

The problem is very simple:

Grab some DOCX document containing more than two comments (so you can check the results). Unzip it.

Investigate Comments part (see Office Open XML Part 1 - Fundamentals And Markup Language Reference.pdf for more details).

Investigate 

xmllint --format word/comments.xml

Grep for comments:

bash-3.2$ xmllint --format word/comments.xml | grep "<w:comment"

Comments are numbered:

  <w:comment w:id="0" w:author="Deborah" w:date="2010-11-19T16:41:00Z" w:initials="D">
  <w:comment w:id="1" w:author="Deborah" w:date="2010-11-19T14:41:00Z" w:initials="D">
  <w:comment w:id="2" w:author="Deborah" w:date="2010-11-19T14:43:00Z" w:initials="D">
  <w:comment w:id="3" w:author="Deborah" w:date="2010-11-19T14:49:00Z" w:initials="D">
  <w:comment w:id="4" w:author="Deborah" w:date="2010-11-19T14:53:00Z" w:initials="D">
  <w:comment w:id="5" w:author="Deborah" w:date="2010-11-19T14:51:00Z" w:initials="D">

According to wml.xsd, attribute id (w:id) is:

  <xsd:complexType name="CT_Markup">
    <xsd:attribute name="id" type="ST_DecimalNumber" use="required"/>
  </xsd:complexType>

but our model (writerfilter/source/ooxml/model.xml) contains:

        <attribute name="id">
          <text/>

which means it is being worked on as a string which is wrong. It should be ST_DecimalNumber.

And thats all.
-- 
Pavel Janík