You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/05 20:42:21 UTC

Review Request: SQOOP-679 Wrap exception to MSubmission metadata object

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7882/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've extended MSubmission structure by exception info and exception stack trace.


This addresses bug SQOOP-679.
    https://issues.apache.org/jira/browse/SQOOP-679


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java d4d682587e6d4b31d218f1f472a9161faab676fa 
  common/src/main/java/org/apache/sqoop/json/SubmissionBean.java d7188f47ed206d196df97f5bebf64d9c0f9f1ee2 
  common/src/main/java/org/apache/sqoop/model/MSubmission.java f8ca32efa67f0010571363e88407c29088927b38 
  common/src/main/java/org/apache/sqoop/submission/SubmissionStatus.java 025690a1a79fdd2180b08474fb953276dda68daa 
  common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 9c5e0438261b5c11f3e2da9c139a896f70e7cb65 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 704992456ddb27f32c23b49b204f9d5406416409 

Diff: https://reviews.apache.org/r/7882/diff/


Testing
-------

I've added additional tests to TestSubmissionBean test case and also perform life testing on my test box.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-679 Wrap exception to MSubmission metadata object

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7882/#review13105
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Nov. 5, 2012, 7:42 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7882/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 7:42 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've extended MSubmission structure by exception info and exception stack trace.
> 
> 
> This addresses bug SQOOP-679.
>     https://issues.apache.org/jira/browse/SQOOP-679
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java d4d682587e6d4b31d218f1f472a9161faab676fa 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java d7188f47ed206d196df97f5bebf64d9c0f9f1ee2 
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java f8ca32efa67f0010571363e88407c29088927b38 
>   common/src/main/java/org/apache/sqoop/submission/SubmissionStatus.java 025690a1a79fdd2180b08474fb953276dda68daa 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 9c5e0438261b5c11f3e2da9c139a896f70e7cb65 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 704992456ddb27f32c23b49b204f9d5406416409 
> 
> Diff: https://reviews.apache.org/r/7882/diff/
> 
> 
> Testing
> -------
> 
> I've added additional tests to TestSubmissionBean test case and also perform life testing on my test box.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>