You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/17 09:53:50 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request, #10492: Open checkstyle, change checkstyle severity from info to warning
ruanwenjun opened a new pull request, #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492
## Purpose of the pull request
Right now, the checkstyle is unused, since we set severity level to info, this means when someone break the checkstyle rule, the will be a info log, the CI/checkstyle task will still pass.
## Brief change log
Change checkstyle severity to warning.
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10492: Open checkstyle, change checkstyle severity from info to warning
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492#discussion_r899975830
##########
.github/workflows/api-test.yml:
##########
@@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
Review Comment:
I think we can skip, we need to add a single checkstyle task, this need to wait we solve the all exist code format errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10492: Open checkstyle, change checkstyle severity from info to warning
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492#discussion_r899973643
##########
.github/workflows/api-test.yml:
##########
@@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
Review Comment:
Should we skip checkstyle in ```e2e.yaml```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10492: Open checkstyle, change checkstyle severity from info to warning
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492#issuecomment-1158740822
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10492)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10492&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10492&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10492&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10492: Open checkstyle, change checkstyle severity from info to warning
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492#discussion_r899976923
##########
.github/workflows/api-test.yml:
##########
@@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
Review Comment:
> I think we can skip, we need to add a single checkstyle task, this need to wait we solve the all exist code format errors.
That would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun merged pull request #10492: Open checkstyle, change checkstyle severity from info to warning
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #10492:
URL: https://github.com/apache/dolphinscheduler/pull/10492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org