You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/02/22 23:26:28 UTC

[GitHub] commons-lang pull request #243: Fix JsonToStringStyleTest.NestingPerson java...

GitHub user mureinik opened a pull request:

    https://github.com/apache/commons-lang/pull/243

    Fix JsonToStringStyleTest.NestingPerson javadoc

    A `{@link}` javadoc can only reference a resolvable class name. The
    `{@link}` tag in `NestingPerson`'s javadoc is thus broken, as it directly
    references `JsonToStringStyle` without qualifying it with the enclosing
    `ToStringStyle` class.
    
    This patch adds the enclosing class to the javadoc, thus "unbreaking"
    the reference.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mureinik/commons-lang javadoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #243
    
----
commit fb833014528684fd65a9712894e32120b32a261d
Author: Allon Mureinik <am...@redhat.com>
Date:   2017-02-22T23:20:47Z

    Fix JsonToStringStyleTest.NestingPerson javadoc
    
    A {@link} javadoc can only reference a resolvable class name. The
    {@link} tag in NestingPerson's javadoc is thus broken, as it directly
    references JsonToStringStyle without qualifying it with the enclosing
    ToStringStyle class.
    
    This patch adds the enclosing class to the javadoc, thus "unbreaking"
    the reference.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #243: Fix JsonToStringStyleTest.NestingPerson javadoc

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/243
  
    
    [![Coverage Status](https://coveralls.io/builds/10305828/badge)](https://coveralls.io/builds/10305828)
    
    Coverage remained the same at 94.53% when pulling **fb833014528684fd65a9712894e32120b32a261d on mureinik:javadoc** into **914844e1b226a1ac7ba45626ecfdfb56e7b2e263 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #243: Fix JsonToStringStyleTest.NestingPerson javadoc

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/243
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #243: Fix JsonToStringStyleTest.NestingPerson java...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/243


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---