You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/29 09:23:59 UTC

[GitHub] [arrow-datafusion] rdettai commented on issue #790: Rework GroupByHash to support grouping by nulls

rdettai commented on issue #790:
URL: https://github.com/apache/arrow-datafusion/issues/790#issuecomment-888956349


   Nice write-up and very interesting discussions! 
   - By feeding the signature as a key to the `HashMap`, are we not hashing the original key twice? I guess this can easily be solved by setting the identity function instead of the default hasher on the `HashMap`  😃
   - Too bad we cannot index into the [builder](https://github.com/apache/arrow-rs/blob/master/arrow/src/array/builder.rs), that would allow us to build the target arrow columns strait away. Can't wait for the switch to arrow2 😉 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org