You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2005/11/29 13:37:06 UTC
svn commit: r349713 - /httpd/httpd/trunk/Makefile.win
Author: colm
Date: Tue Nov 29 04:37:03 2005
New Revision: 349713
URL: http://svn.apache.org/viewcvs?rev=349713&view=rev
Log:
Correct a syntax error detected by MSVC2005
Modified:
httpd/httpd/trunk/Makefile.win
Modified: httpd/httpd/trunk/Makefile.win
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/Makefile.win?rev=349713&r1=349712&r2=349713&view=diff
==============================================================================
--- httpd/httpd/trunk/Makefile.win (original)
+++ httpd/httpd/trunk/Makefile.win Tue Nov 29 04:37:03 2005
@@ -127,7 +127,7 @@
!IFNDEF MAKEOPT
# Only default the behavior if MAKEOPT= is omitted
-!IF "$(MAKE)" == "NMAKE"
+!IF "($MAKE)" == "NMAKE"
# Microsoft NMake options
MAKEOPT=-nologo
!ELSEIF "($MAKE)" == "make"
Re: svn commit: r349713 - /httpd/httpd/trunk/Makefile.win
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
The syntax is $(MAKE).
Sorry I missed this. And I still see no discussion of removing the module,
perhaps you have a pointer to the archives? And what error were you seeing?
All for supporting VisualStudio 2005, but this isn't the end of the headaches.
Bill
Colm MacCarthaigh wrote:
> I'm not near my windows box, and the universal inability of any search
> engine to allow me to search for the literal string "$MAKE" is geting to
> me.
>
> Does anyone know exactly which is correct;
>
> "$MAKE"
> or
> "($MAKE)"
>
> I can reverse engineer the answer tomorrow, but it's still annoying me
> now. It looks to me, and some others, like the latter would evaluate to
> "(NMAKE)" and yet when I made the change it got rid of the syntax error,
> and it looked like a compile with /nologo. Is nmake syntax really that
> broken?
>
> On Tue, Nov 29, 2005 at 12:37:06PM -0000, colm@apache.org wrote:
>
>>Modified: httpd/httpd/trunk/Makefile.win
>>URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/Makefile.win?rev=349713&r1=349712&r2=349713&view=diff
>>==============================================================================
>>--- httpd/httpd/trunk/Makefile.win (original)
>>+++ httpd/httpd/trunk/Makefile.win Tue Nov 29 04:37:03 2005
>>@@ -127,7 +127,7 @@
>>
>> !IFNDEF MAKEOPT
>> # Only default the behavior if MAKEOPT= is omitted
>>-!IF "$(MAKE)" == "NMAKE"
>>+!IF "($MAKE)" == "NMAKE"
>> # Microsoft NMake options
>> MAKEOPT=-nologo
>> !ELSEIF "($MAKE)" == "make"
>>
Re: svn commit: r349713 - /httpd/httpd/trunk/Makefile.win
Posted by Colm MacCarthaigh <co...@stdlib.net>.
On Tue, Nov 29, 2005 at 10:36:31PM +0000, Colm MacCarthaigh wrote:
> I can reverse engineer the answer tomorrow, but it's still annoying me
> now. It looks to me, and some others, like the latter would evaluate to
> "(NMAKE)" and yet when I made the change it got rid of the syntax error,
> and it looked like a compile with /nologo. Is nmake syntax really that
> broken?
Terminal services and an ssh-tunnel later, figured it out, $MAKE no
longer evaluates to "NMAKE" but more something like "C:\program
files\Microsoft Visual Studio 8\VC\BIN\nmake.exe" which is what's really
causing the problem.
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net
Re: svn commit: r349713 - /httpd/httpd/trunk/Makefile.win
Posted by Colm MacCarthaigh <co...@stdlib.net>.
I'm not near my windows box, and the universal inability of any search
engine to allow me to search for the literal string "$MAKE" is geting to
me.
Does anyone know exactly which is correct;
"$MAKE"
or
"($MAKE)"
I can reverse engineer the answer tomorrow, but it's still annoying me
now. It looks to me, and some others, like the latter would evaluate to
"(NMAKE)" and yet when I made the change it got rid of the syntax error,
and it looked like a compile with /nologo. Is nmake syntax really that
broken?
On Tue, Nov 29, 2005 at 12:37:06PM -0000, colm@apache.org wrote:
> Modified: httpd/httpd/trunk/Makefile.win
> URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/Makefile.win?rev=349713&r1=349712&r2=349713&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/Makefile.win (original)
> +++ httpd/httpd/trunk/Makefile.win Tue Nov 29 04:37:03 2005
> @@ -127,7 +127,7 @@
>
> !IFNDEF MAKEOPT
> # Only default the behavior if MAKEOPT= is omitted
> -!IF "$(MAKE)" == "NMAKE"
> +!IF "($MAKE)" == "NMAKE"
> # Microsoft NMake options
> MAKEOPT=-nologo
> !ELSEIF "($MAKE)" == "make"
>
>
>
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net