You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/07/06 20:57:12 UTC

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #27384: [Python] Make BigQuery load job names deterministic for retry resilience

ahmedabu98 commented on code in PR #27384:
URL: https://github.com/apache/beam/pull/27384#discussion_r1254912108


##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py:
##########
@@ -1041,7 +1043,7 @@ def test_bqfl_streaming_with_copy_jobs(self):
 
     # Override these parameters to induce copy jobs
     bqfl._DEFAULT_MAX_FILE_SIZE = 100
-    bqfl._MAXIMUM_LOAD_SIZE = 400
+    bqfl._MAXIMUM_LOAD_SIZE = 200

Review Comment:
   was running a bunch of these tests after my changes to verify they were passing and found that the size set here was too high and that copy jobs weren't actually being induced. I lowered the value so that the test runs copy jobs as expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org