You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/27 02:11:18 UTC
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
zhongjiajie commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859312555
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
if we do not use `dolphinscheduler_env.sh` file anymore, we should also remove the assembly config https://github.com/apache/dolphinscheduler/blob/de50f43de63e42488cb38169cd56fba77dd24fc6/dolphinscheduler-tools/src/main/assembly/dolphinscheduler-tools.xml#L41-L49
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
+* Some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`.
+* Registry center `zookeeper`.
+* Server related configuration, such as cache type, timezone, etc.
+
+You could ignore the task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
related configurations based on your environment.
-```sh
+```shell
# JAVA_HOME, will use it to start DolphinScheduler server
-export JAVA_HOME=${JAVA_HOME:-/custom/path}
+export JAVA_HOME=${JAVA_HOME:-/opt/soft/java}
# Database related configuration, set database type, username and password
export DATABASE=${DATABASE:-postgresql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
-export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler"
-export SPRING_DATASOURCE_USERNAME="username"
-export SPRING_DATASOURCE_PASSWORD="password"
+export SPRING_DATASOURCE_URL=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
+export SPRING_DATASOURCE_USERNAME={user}
+export SPRING_DATASOURCE_PASSWORD={password}
Review Comment:
why we use `{user}` and `{password}` instead of exactly string value
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
Review Comment:
Add one more blank line will be more confortable
```suggestion
* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
```
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
Review Comment:
Same as ZH docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org