You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/12/31 09:22:27 UTC
[GitHub] [incubator-inlong] luchunliang opened a new pull request #2091: [INLONG-2075] TDSDK Source of DataProxy support new Message format.
luchunliang opened a new pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091
### Title Name: [INLONG-2075][Inlong-DataProxy] TDSDK Source of DataProxy support new Message format.
Fixes #2075
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu commented on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu commented on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1007873804
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu commented on a change in pull request #2091: [INLONG-2075] TDSDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu commented on a change in pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#discussion_r777783682
##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/ServerMessageHandler.java
##########
@@ -408,49 +417,72 @@ private void formatMessagesAndSend(Map<String, String> commonAttrMap,
StringBuilder sidBuilder = new StringBuilder();
sidBuilder.append(topicEntry.getKey()).append(SEPARATOR).append(streamIdEntry.getKey())
- .append(SEPARATOR).append(sequenceId);
+ .append(SEPARATOR).append(sequenceId);
headers.put(ConfigConstants.SEQUENCE_ID, sidBuilder.toString());
}
headers.put(ConfigConstants.PKG_TIME_KEY, pkgTimeStr);
- Event event = EventBuilder.withBody(data, headers);
- long dtten = 0;
- try {
- dtten = Long.parseLong(headers.get(AttributeConstants.DATA_TIME));
- } catch (Exception e1) {
- long uniqVal = Long.parseLong(commonAttrMap.get(AttributeConstants.UNIQ_ID));
- throw new MessageIDException(uniqVal,
- ErrorCode.DT_ERROR,
- new Throwable("attribute dt=" + headers.get(AttributeConstants.DATA_TIME
- + " has error, detail is: topic=" + topicEntry.getKey() + "&streamId="
- + streamIdEntry.getKey() + "&NodeIP=" + strRemoteIP), e1));
- }
+ // process proxy message list
+ this.processProxyMessageList(headers, streamIdEntry.getValue());
Review comment:
the message of tdmsg format is deleted? the tdmsg format needs to be retained. And new message format need add tow new file for messagehandler and sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2091: [INLONG-2075] TDSDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003327015
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2091](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72f4474) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/f5fd3a2afee6b6e5a3f234bc53ec55c3a9114049?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5fd3a2) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2091 +/- ##
============================================
- Coverage 12.28% 12.27% -0.02%
+ Complexity 1157 1156 -1
============================================
Files 413 413
Lines 35215 35215
Branches 5542 5542
============================================
- Hits 4325 4321 -4
- Misses 30119 30125 +6
+ Partials 771 769 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../client/producer/qltystats/BrokerStatsItemSet.java](https://codecov.io/gh/apache/incubator-inlong/pull/2091/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvQnJva2VyU3RhdHNJdGVtU2V0LmphdmE=) | `67.44% <0.00%> (-4.66%)` | :arrow_down: |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/2091/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `44.53% <0.00%> (-0.79%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5fd3a2...72f4474](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003327015
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2091](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74c69ff) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/f5fd3a2afee6b6e5a3f234bc53ec55c3a9114049?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5fd3a2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2091 +/- ##
=========================================
Coverage 12.28% 12.28%
Complexity 1157 1157
=========================================
Files 413 413
Lines 35215 35215
Branches 5542 5542
=========================================
Hits 4325 4325
Misses 30119 30119
Partials 771 771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5fd3a2...74c69ff](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003327015
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2091](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (281af6f) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/f5fd3a2afee6b6e5a3f234bc53ec55c3a9114049?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5fd3a2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2091 +/- ##
=========================================
Coverage 12.28% 12.28%
Complexity 1157 1157
=========================================
Files 413 413
Lines 35215 35215
Branches 5542 5542
=========================================
Hits 4325 4325
Misses 30119 30119
Partials 771 771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5fd3a2...281af6f](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu commented on pull request #2091: [INLONG-2075] TDSDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu commented on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003378059
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003327015
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2091](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51ae60e) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/f5fd3a2afee6b6e5a3f234bc53ec55c3a9114049?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5fd3a2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2091 +/- ##
=========================================
Coverage 12.28% 12.28%
Complexity 1157 1157
=========================================
Files 413 413
Lines 35215 35215
Branches 5542 5542
=========================================
Hits 4325 4325
Misses 30119 30119
Partials 771 771
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5fd3a2...51ae60e](https://codecov.io/gh/apache/incubator-inlong/pull/2091?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu removed a comment on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu removed a comment on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1007873804
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu removed a comment on pull request #2091: [INLONG-2075] TDSDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu removed a comment on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1003378059
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu commented on pull request #2091: [INLONG-2075] SDK Source of DataProxy support new Message format.
Posted by GitBox <gi...@apache.org>.
baomingyu commented on pull request #2091:
URL: https://github.com/apache/incubator-inlong/pull/2091#issuecomment-1007873804
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org