You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/18 00:11:30 UTC
[GitHub] [incubator-mxnet] DickJC123 opened a new issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
DickJC123 opened a new issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753
## Description
Could our system be changed to prevent merging of a CI-passing PR after a "merge window" has elapsed? I guess this is not normally a problem since after a time an auto-merge would fail and the PR becomes unmergable, right?
PR https://github.com/apache/incubator-mxnet/pull/18197, merged today having passed CI 2 months ago, becomes the poster-child for this issue. Thanks @leezu for submitting reverting PR https://github.com/apache/incubator-mxnet/pull/18750.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753#issuecomment-662534016
When my in-development PRs become unmergeable due to other accepted PRs, I merge the current master with my PR and push the result, which generates another CI run. Is it possible that the PR I mentioned above, after 2 months was still mergeable? Or is there some other way to fix merge conflicts in a way that doesn't require a repeated CI run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753#issuecomment-662114180
Agree, that should be easy to solve by having a lambda function triggered nightly which invalidates status checks which are older than a certain time period.
@ChaiBapchya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753#issuecomment-662538274
Since resolving a merge conflict will always result in a new commit hash, it's inevitable that it's rerun by CI.
Merge conflict or not - a PR status should go stale after some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753#issuecomment-662253212
Let's start with 2 weeks - as long as it's configurable :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #18753: PRs that have passed CI, but have "aged" considerably w.r.t. master, can still be merged.
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #18753:
URL: https://github.com/apache/incubator-mxnet/issues/18753#issuecomment-662243953
Sure that should be doable. And what would be that time period? 2/4/8 weeks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org