You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Davide Giannella <da...@apache.org> on 2016/03/01 18:21:05 UTC
[1.4.0][blocked] oak-examples and circular dependencies on oak itself
Good morning team,
I'm kind-of stuck in the release process as oak-examples contains
dependencies to oak-1.4-SNAPSHOT. The problem is the -SNAPSHOT bit.
mvn release plugin complains about it as it's -SNAPSHOT and asks if I'd
like to fix it.
While we could potentially proceed without fixing, I think, I'd rather
have a clean solution if we have.
I tried setting the latest unstable (1.3.16) but it complains with
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.3.2:prepare
(default-cli) on project jackrabbit-oak: The artifact
(org.apache.jackrabbit:oak-jcr) requires a different version (1.4.0)
than what is found (1.3.16) for the expression (oak.version) in the
project (org.apache.jackrabbit:oak-webapp). -> [Help 1]
If we set something like ${project.version} it will of course complain
about it during the release process as it will be converted to 1.4.0 and
it doesn't exists.
We could potentially set it to 1.6-SNAPSHOT (didn't try it yet) but
still it's a SNAPSHOT and it's referring to a different, more advanced
oak version.
I tried as well to see if there are any flags of the maven release
plugin to completely skip a module but found only for the deployment part.
Possible solutions I have in mind from here
1) we delete the module from 1.4. In the end is an example and could
live in trunk only.
2) we give it something like, 1.4-SNAPSHOT or 1.6-SNAPSHOT for allowing
the release to proceed (assuming it will). Then once 1.4.0 is public we
switch it back to 1.4.0 and then it should be set.
Any ideas?
Cheers
Davide
On 01/03/2016 16:59, davide@apache.org wrote:
> Author: davide
> Date: Tue Mar 1 16:59:00 2016
> New Revision: 1733103
>
> URL: http://svn.apache.org/viewvc?rev=1733103&view=rev
> Log:
> OAK-4073 - Release Oak 1.4.0
>
> trying to address circular snapshot dependencies in
> oak-examples. Setting the oak version to 1.3.16: last known unstable
> cut.
>
> It should not be a problem as this is not part of the release. When
> 1.4.0 will be available we can set it to the stable version.
>
>
> Modified:
> jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml
> jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml
>
> Modified: jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml?rev=1733103&r1=1733102&r2=1733103&view=diff
> ==============================================================================
> --- jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml (original)
> +++ jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml Tue Mar 1 16:59:00 2016
> @@ -35,7 +35,7 @@
> <description>Standalone application based on Spring Boot then embeds a Jackrabbit Oak content repository</description>
>
> <properties>
> - <oak.version>1.4-SNAPSHOT</oak.version>
> + <oak.version>1.3.16</oak.version>
> <tika.version>1.7</tika.version>
> <skip.deployment>true</skip.deployment>
> <spring.boot.version>1.3.0.RELEASE</spring.boot.version>
>
> Modified: jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml?rev=1733103&r1=1733102&r2=1733103&view=diff
> ==============================================================================
> --- jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml (original)
> +++ jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml Tue Mar 1 16:59:00 2016
> @@ -35,7 +35,7 @@
> <description>Web application that hosts and serves a Jackrabbit Oak content repository</description>
>
> <properties>
> - <oak.version>1.4-SNAPSHOT</oak.version>
> + <oak.version>1.3.16</oak.version>
> <tomcat.version>7.0.40</tomcat.version>
> <tika.version>1.7</tika.version>
> <skip.deployment>true</skip.deployment>
>
>
Re: [1.4.0][blocked] oak-examples and circular dependencies on oak
itself
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
On 02/03/16 08:36, "Marcel Reutegger" wrote:
>On 01/03/16 18:21, "Davide Giannella" wrote:
>>I'm kind-of stuck in the release process as oak-examples contains
>>dependencies to oak-1.4-SNAPSHOT. The problem is the -SNAPSHOT bit.
>>
>>mvn release plugin complains about it as it's -SNAPSHOT and asks if I'd
>>like to fix it.
>
>I think it works if you change the version from 1.4-SNAPSHOT to
>1.4.0-SNAPSHOT as you did with for the other modules.
>
>the release plugin will take care of rewriting it to the release
>version. see previous release:
>
>http://svn.apache.org/viewvc?rev=1730666&view=rev
changed the version accordingly on the 1.4 branch:
http://svn.apache.org/r1733227
and also set it to 1.6-SNAPSHOT in trunk:
http://svn.apache.org/r1733228
Regards
Marcel
Re: [1.4.0][blocked] oak-examples and circular dependencies on oak
itself
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
On 01/03/16 18:21, "Davide Giannella" wrote:
>Good morning team,
>
>I'm kind-of stuck in the release process as oak-examples contains
>dependencies to oak-1.4-SNAPSHOT. The problem is the -SNAPSHOT bit.
>
>mvn release plugin complains about it as it's -SNAPSHOT and asks if I'd
>like to fix it.
I think it works if you change the version from 1.4-SNAPSHOT to
1.4.0-SNAPSHOT as you did with for the other modules.
the release plugin will take care of rewriting it to the release
version. see previous release:
http://svn.apache.org/viewvc?rev=1730666&view=rev
Regards
Marcel
>
>While we could potentially proceed without fixing, I think, I'd rather
>have a clean solution if we have.
>
>I tried setting the latest unstable (1.3.16) but it complains with
>
>[ERROR] Failed to execute goal
>org.apache.maven.plugins:maven-release-plugin:2.3.2:prepare
>(default-cli) on project jackrabbit-oak: The artifact
>(org.apache.jackrabbit:oak-jcr) requires a different version (1.4.0)
>than what is found (1.3.16) for the expression (oak.version) in the
>project (org.apache.jackrabbit:oak-webapp). -> [Help 1]
>
>If we set something like ${project.version} it will of course complain
>about it during the release process as it will be converted to 1.4.0 and
>it doesn't exists.
>
>We could potentially set it to 1.6-SNAPSHOT (didn't try it yet) but
>still it's a SNAPSHOT and it's referring to a different, more advanced
>oak version.
>
>I tried as well to see if there are any flags of the maven release
>plugin to completely skip a module but found only for the deployment part.
>
>Possible solutions I have in mind from here
>
>1) we delete the module from 1.4. In the end is an example and could
>live in trunk only.
>
>2) we give it something like, 1.4-SNAPSHOT or 1.6-SNAPSHOT for allowing
>the release to proceed (assuming it will). Then once 1.4.0 is public we
>switch it back to 1.4.0 and then it should be set.
>
>Any ideas?
>
>Cheers
>Davide
>
>On 01/03/2016 16:59, davide@apache.org wrote:
>> Author: davide
>> Date: Tue Mar 1 16:59:00 2016
>> New Revision: 1733103
>>
>> URL: http://svn.apache.org/viewvc?rev=1733103&view=rev
>> Log:
>> OAK-4073 - Release Oak 1.4.0
>>
>> trying to address circular snapshot dependencies in
>> oak-examples. Setting the oak version to 1.3.16: last known unstable
>> cut.
>>
>> It should not be a problem as this is not part of the release. When
>> 1.4.0 will be available we can set it to the stable version.
>>
>>
>> Modified:
>> jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml
>> jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml
>>
>> Modified: jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml
>> URL:
>>http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.4/oak-examples/sta
>>ndalone/pom.xml?rev=1733103&r1=1733102&r2=1733103&view=diff
>>
>>=========================================================================
>>=====
>> --- jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml
>>(original)
>> +++ jackrabbit/oak/branches/1.4/oak-examples/standalone/pom.xml Tue Mar
>> 1 16:59:00 2016
>> @@ -35,7 +35,7 @@
>> <description>Standalone application based on Spring Boot then embeds
>>a Jackrabbit Oak content repository</description>
>>
>> <properties>
>> - <oak.version>1.4-SNAPSHOT</oak.version>
>> + <oak.version>1.3.16</oak.version>
>> <tika.version>1.7</tika.version>
>> <skip.deployment>true</skip.deployment>
>> <spring.boot.version>1.3.0.RELEASE</spring.boot.version>
>>
>> Modified: jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml
>> URL:
>>http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.4/oak-examples/web
>>app/pom.xml?rev=1733103&r1=1733102&r2=1733103&view=diff
>>
>>=========================================================================
>>=====
>> --- jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml (original)
>> +++ jackrabbit/oak/branches/1.4/oak-examples/webapp/pom.xml Tue Mar 1
>>16:59:00 2016
>> @@ -35,7 +35,7 @@
>> <description>Web application that hosts and serves a Jackrabbit Oak
>>content repository</description>
>>
>> <properties>
>> - <oak.version>1.4-SNAPSHOT</oak.version>
>> + <oak.version>1.3.16</oak.version>
>> <tomcat.version>7.0.40</tomcat.version>
>> <tika.version>1.7</tika.version>
>> <skip.deployment>true</skip.deployment>
>>
>>
>
Re: [1.4.0][blocked] oak-examples and circular dependencies on oak itself
Posted by Amit Jain <am...@ieee.org>.
Hi Davide,
The maven release plugin does change the version in the oak.version
property for oak-examples See [1] for 1.3.16 release.
I think what is causing problems is that the oak.version property should
also have version 1.4.0-SNAPSHOT instead of 1.4-SNAPSHOT as was changed for
the main artifacts [2].
Thanks
Amit
[1]
https://github.com/apache/jackrabbit-oak/commit/58fc76337851c5a1f557da9e55743f1a1c604115
[2]
https://github.com/apache/jackrabbit-oak/commit/59744433913619cff224547c5e6578395ba8b7e9
On Tue, Mar 1, 2016 at 11:11 PM, Chetan Mehrotra <ch...@gmail.com>
wrote:
> On Tue, Mar 1, 2016 at 10:51 PM, Davide Giannella <da...@apache.org>
> wrote:
> > I'm kind-of stuck in the release process as oak-examples contains
> > dependencies to oak-1.4-SNAPSHOT. The problem is the -SNAPSHOT bit.
>
> Wondering how it used to work so far for various 1.3.x releases
>
> One approach we can try is get rid of oak.version and make use of
> project.version. Such a way should be similar to how oak-lucene
> depends on oak-core and hence should work
>
> Chetan Mehrotra
>
Re: [1.4.0][blocked] oak-examples and circular dependencies on oak itself
Posted by Chetan Mehrotra <ch...@gmail.com>.
On Tue, Mar 1, 2016 at 10:51 PM, Davide Giannella <da...@apache.org> wrote:
> I'm kind-of stuck in the release process as oak-examples contains
> dependencies to oak-1.4-SNAPSHOT. The problem is the -SNAPSHOT bit.
Wondering how it used to work so far for various 1.3.x releases
One approach we can try is get rid of oak.version and make use of
project.version. Such a way should be similar to how oak-lucene
depends on oak-core and hence should work
Chetan Mehrotra