[GitHub] [iotdb] MrQuansy commented on a diff in pull request #5989: [IOTDB-3231] Return detailed failure message for opening a client

[GitBox <gi...@apache.org>]

MrQuansy commented on code in PR #5989:
URL: https://github.com/apache/iotdb/pull/5989#discussion_r879102028


##########
server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeTSIServiceImpl.java:
##########
@@ -141,7 +142,13 @@ public DataNodeTSIServiceImpl() {
   @Override
   public TSOpenSessionResp openSession(TSOpenSessionReq req) throws TException {
     IoTDBConstant.ClientVersion clientVersion = parseClientVersion(req);
-    TSStatus loginStatus = AuthorityChecker.checkUser(req.username, req.password);
+    TSStatus loginStatus;
+    try {
+      loginStatus = AuthorityChecker.checkUser(req.username, req.password);
+    } catch (ConfigNodeConnectionException e) {
+      TSStatus tsStatus = RpcUtils.getStatus(TSStatusCode.INTERNAL_SERVER_ERROR, e.getMessage());

Review Comment:
   Maybe we need to add a new TSStatusCode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org