[GitHub] [calcite] danny0405 commented on a change in pull request #1568: [CALCITE-3486]MysqlSqlDialect unparse ROW keyword does not exist

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1568: [CALCITE-3486]MysqlSqlDialect unparse ROW keyword does not exist
URL: https://github.com/apache/calcite/pull/1568#discussion_r344468474
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java
 ##########
 @@ -179,6 +179,9 @@ public boolean supportsAliasedValues() {
 
       unparseFloor(writer, call);
       break;
+    case ROW:
+      unparseRow(writer, call);
 
 Review comment:
   Thanks for the fix @quxiucheng, i think this patch can be promoted a little, we can move this logic to the parent class `SqlDialect`, you can get the `SqlConformance` from the dialect and decide if we should generates the `ROW` keyword based on method `SqlConformance#allowExplicitRowValueConstructor `.
   
   [1] https://github.com/apache/calcite/blob/4d1c3e54fc4172c7ff00db3326823c42f237cf04/core/src/main/java/org/apache/calcite/sql/validate/SqlConformance.java#L296
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services