You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/17 06:55:53 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4797: Refactor RowsEventPacket to database/protocol module

KomachiSion opened a new pull request #4797: Refactor RowsEventPacket to database/protocol module
URL: https://github.com/apache/incubator-shardingsphere/pull/4797
 
 
   For #4594 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4797: Refactor RowsEventPacket to database/protocol module

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4797: Refactor RowsEventPacket to database/protocol module
URL: https://github.com/apache/incubator-shardingsphere/pull/4797
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4797: Refactor RowsEventPacket to database/protocol module

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4797: Refactor RowsEventPacket to database/protocol module
URL: https://github.com/apache/incubator-shardingsphere/pull/4797#issuecomment-599918016
 
 
   ## Pull Request Test Coverage Report for [Build 10305](https://coveralls.io/builds/29411343)
   
   * **74** of **75**   **(98.67%)**  changed or added relevant lines in **4** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.1%**) to **59.857%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/MySQLBinlogRowsEventPacket.java](https://coveralls.io/builds/29411343/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpacket%2Fbinlog%2Frow%2FMySQLBinlogRowsEventPacket.java#L118) | 31 | 32 | 96.88%
   <!-- | **Total:** | **74** | **75** | **98.67%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29411343/badge)](https://coveralls.io/builds/29411343) |
   | :-- | --: |
   | Change from base [Build 10298](https://coveralls.io/builds/29410768): |  0.1% |
   | Covered Lines: | 12540 |
   | Relevant Lines: | 20950 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4797: Refactor RowsEventPacket to database/protocol module

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4797: Refactor RowsEventPacket to database/protocol module
URL: https://github.com/apache/incubator-shardingsphere/pull/4797#issuecomment-599918016
 
 
   ## Pull Request Test Coverage Report for [Build 2128](https://coveralls.io/builds/29411161)
   
   * **74** of **75**   **(98.67%)**  changed or added relevant lines in **4** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.1%**) to **59.861%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/MySQLBinlogRowsEventPacket.java](https://coveralls.io/builds/29411161/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpacket%2Fbinlog%2Frow%2FMySQLBinlogRowsEventPacket.java#L118) | 31 | 32 | 96.88%
   <!-- | **Total:** | **74** | **75** | **98.67%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29411161/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29411161/badge)](https://coveralls.io/builds/29411161) |
   | :-- | --: |
   | Change from base [Build 10298](https://coveralls.io/builds/29410768): |  0.1% |
   | Covered Lines: | 12545 |
   | Relevant Lines: | 20957 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services