You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/09 17:32:14 UTC
Review Request 47128: add release call when GatewaySenderEventImpl
removed from tempQueue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47128/
-----------------------------------------------------------
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1282
https://issues.apache.org/jira/browse/GEODE-1282
Repository: geode
Description
-------
Any time a GatewaySenderEventImpl can become garbage it needs to first have release called on it.
This prevents any off-heap memory it is referencing from never being released.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java 09f70a66c94dd4128aec76d90a9bc1beff720317
Diff: https://reviews.apache.org/r/47128/diff/
Testing
-------
precheckin and off-heap wan orphan tests
Thanks,
Darrel Schneider
Re: Review Request 47128: add release call when GatewaySenderEventImpl
removed from tempQueue
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47128/#review132556
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On May 9, 2016, 5:32 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47128/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 5:32 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1282
> https://issues.apache.org/jira/browse/GEODE-1282
>
>
> Repository: geode
>
>
> Description
> -------
>
> Any time a GatewaySenderEventImpl can become garbage it needs to first have release called on it.
> This prevents any off-heap memory it is referencing from never being released.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java 09f70a66c94dd4128aec76d90a9bc1beff720317
>
> Diff: https://reviews.apache.org/r/47128/diff/
>
>
> Testing
> -------
>
> precheckin and off-heap wan orphan tests
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47128: add release call when GatewaySenderEventImpl
removed from tempQueue
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47128/#review132545
-----------------------------------------------------------
Ship it!
OK, that's pretty straight forward
- Ken Howe
On May 9, 2016, 5:32 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47128/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 5:32 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1282
> https://issues.apache.org/jira/browse/GEODE-1282
>
>
> Repository: geode
>
>
> Description
> -------
>
> Any time a GatewaySenderEventImpl can become garbage it needs to first have release called on it.
> This prevents any off-heap memory it is referencing from never being released.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java 09f70a66c94dd4128aec76d90a9bc1beff720317
>
> Diff: https://reviews.apache.org/r/47128/diff/
>
>
> Testing
> -------
>
> precheckin and off-heap wan orphan tests
>
>
> Thanks,
>
> Darrel Schneider
>
>