[GitHub] [hadoop] ajayydv commented on a change in pull request #920: HDDS-1545. Cli to add, remove, get and delete acls for Ozone objects. Contributed by Ajay Kumar.

[GitBox <gi...@apache.org>]

ajayydv commented on a change in pull request #920: HDDS-1545. Cli to add,remove,get and delete acls for Ozone objects. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/920#discussion_r291856381
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneAclConfig.java
 ##########
 @@ -40,6 +40,9 @@
           "OzoneManager."
   )
   public void setUserDefaultRights(String userRights) {
+    if(userRights == null) {
 
 Review comment:
   This results in NPE in MR robot tests. While instantiating RPC client via reflection we get userRights as null which results in NPE.  Also from config point if userRights is null it means user hasn't set any value for it, so it should fallback to default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org