You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2012/10/28 19:27:12 UTC

[jira] [Created] (HDFS-4123) HDFS logs should print stack trace and add a comment where it is intentionally not printed

Suresh Srinivas created HDFS-4123:
-------------------------------------

             Summary: HDFS logs should print stack trace and add a comment where it is intentionally not printed
                 Key: HDFS-4123
                 URL: https://issues.apache.org/jira/browse/HDFS-4123
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Suresh Srinivas
            Priority: Minor


Review the code and change the logs to print stack trace by changing the code from:
{noformat}
  LOG.info("message" + exception)
{noformat}

to:
{noformat}
  LOG.info("message", exception)
{noformat}

Where printing exception stack trace is avoided, add a comment to indicate that intent, to avoid someone changing it to print full stack trace.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4123) HDFS logs should print stack trace and add a comment where it is intentionally not printed

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491162#comment-13491162 ] 

Suresh Srinivas commented on HDFS-4123:
---------------------------------------

This may not be a newbie. It should be done by someone with the background to decide whether stack trace is intentionally not printed.
                
> HDFS logs should print stack trace and add a comment where it is intentionally not printed
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4123
>                 URL: https://issues.apache.org/jira/browse/HDFS-4123
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Suresh Srinivas
>            Priority: Minor
>
> Review the code and change the logs to print stack trace by changing the code from:
> {noformat}
>   LOG.info("message" + exception)
> {noformat}
> to:
> {noformat}
>   LOG.info("message", exception)
> {noformat}
> Where printing exception stack trace is avoided, add a comment to indicate that intent, to avoid someone changing it to print full stack trace.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4123) HDFS logs should print stack trace and add a comment where it is intentionally not printed

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-4123:
------------------------------

    Labels: newbie  (was: )
    
> HDFS logs should print stack trace and add a comment where it is intentionally not printed
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4123
>                 URL: https://issues.apache.org/jira/browse/HDFS-4123
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Suresh Srinivas
>            Priority: Minor
>              Labels: newbie
>
> Review the code and change the logs to print stack trace by changing the code from:
> {noformat}
>   LOG.info("message" + exception)
> {noformat}
> to:
> {noformat}
>   LOG.info("message", exception)
> {noformat}
> Where printing exception stack trace is avoided, add a comment to indicate that intent, to avoid someone changing it to print full stack trace.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4123) HDFS logs should print stack trace and add a comment where it is intentionally not printed

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-4123:
----------------------------------

    Labels:   (was: newbie)
    
> HDFS logs should print stack trace and add a comment where it is intentionally not printed
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4123
>                 URL: https://issues.apache.org/jira/browse/HDFS-4123
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Suresh Srinivas
>            Priority: Minor
>
> Review the code and change the logs to print stack trace by changing the code from:
> {noformat}
>   LOG.info("message" + exception)
> {noformat}
> to:
> {noformat}
>   LOG.info("message", exception)
> {noformat}
> Where printing exception stack trace is avoided, add a comment to indicate that intent, to avoid someone changing it to print full stack trace.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira