Re: [PR] fix: format decimal to string when casting to short [datafusion-comet]

["manuzhang (via GitHub)" <gi...@apache.org>]

manuzhang commented on code in PR #2916:
URL: https://github.com/apache/datafusion-comet/pull/2916#discussion_r2635601167


##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1030,7 +1030,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
 
   test("cast between decimals with higher precision than source") {
     // cast between Decimal(10, 2) to Decimal(10,4)
-    castTest(generateDecimalsPrecision10Scale2(), DataTypes.createDecimalType(10, 4))
+    castTest(

Review Comment:
   @andygrove I've reworked my PR. Could you please check again?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org