[GitHub] [netbeans] matthiasblaesing commented on pull request #5170: upgrade bundled maven to 3.8.7

[GitBox <gi...@apache.org>]

matthiasblaesing commented on PR #5170:
URL: https://github.com/apache/netbeans/pull/5170#issuecomment-1368507812

   @mbien you are seeing a problem in the build process (or better the result of) `netbeans-eventspy.jar`. The error message indicates, that `org.json.simple.JSONObject` is not found. But according to the build process, it should not even be there as it is shaded to `org.netbeans.shaded.json.simple.JSONObject`:
   
   https://github.com/apache/netbeans/blob/604cf9d0babc9ef7ceef84fbe8082341d1c8ddf1/java/maven/build.xml#L58-L65
   
   I decompiled the resulting `NbEventSpy` class and indeed it contained the original reference, not the shaded one. Some more googling showed, that the used `jarjar`  version we use fails to work with JDK 8+ class files. An updated `jarjar` version fixes that.
   
   Please have a look here: https://github.com/matthiasblaesing/netbeans/tree/pr-5170. And/or here: https://github.com/matthiasblaesing/netbeans/commit/d9d130932f9edc0893b5c532b99f7fb3ebd91204.
   
   Feel free to pull it in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists