You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Nebojsa Sabovic (Created) (JIRA)" <ji...@apache.org> on 2011/11/07 04:54:54 UTC
[jira] [Created] (AVRO-954) C++ - Typo in JsonCodec.cc
C++ - Typo in JsonCodec.cc
--------------------------
Key: AVRO-954
URL: https://issues.apache.org/jira/browse/AVRO-954
Project: Avro
Issue Type: Bug
Components: c++
Affects Versions: 1.6.0
Reporter: Nebojsa Sabovic
Assignee: Nebojsa Sabovic
Priority: Minor
JsonCodec.cc has a line that reads: if (isdigit(ch) || '-')
This doesn't do anything useful, we should change it to read: if (isdigit(ch) || ch == '-')
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-954) C++ - Typo in JsonCodec.cc
Posted by "Thiruvalluvan M. G. (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145507#comment-13145507 ]
Thiruvalluvan M. G. commented on AVRO-954:
------------------------------------------
Good catch. +1.
> C++ - Typo in JsonCodec.cc
> --------------------------
>
> Key: AVRO-954
> URL: https://issues.apache.org/jira/browse/AVRO-954
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.6.0
> Reporter: Nebojsa Sabovic
> Assignee: Nebojsa Sabovic
> Priority: Minor
> Labels: c++
> Attachments: AVRO-954.patch
>
>
> JsonCodec.cc has a line that reads: if (isdigit(ch) || '-')
> This doesn't do anything useful, we should change it to read: if (isdigit(ch) || ch == '-')
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-954) C++ - Typo in JsonCodec.cc
Posted by "Nebojsa Sabovic (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nebojsa Sabovic updated AVRO-954:
---------------------------------
Attachment: AVRO-954.patch
> C++ - Typo in JsonCodec.cc
> --------------------------
>
> Key: AVRO-954
> URL: https://issues.apache.org/jira/browse/AVRO-954
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.6.0
> Reporter: Nebojsa Sabovic
> Assignee: Nebojsa Sabovic
> Priority: Minor
> Labels: c++
> Attachments: AVRO-954.patch
>
>
> JsonCodec.cc has a line that reads: if (isdigit(ch) || '-')
> This doesn't do anything useful, we should change it to read: if (isdigit(ch) || ch == '-')
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-954) C++ - Typo in JsonCodec.cc
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-954:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 1328833.
After adjusting for the recent changes in change in location of Json code. Thank you Nebojsa Sabovic
> C++ - Typo in JsonCodec.cc
> --------------------------
>
> Key: AVRO-954
> URL: https://issues.apache.org/jira/browse/AVRO-954
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.6.0
> Reporter: Nebojsa Sabovic
> Assignee: Nebojsa Sabovic
> Priority: Minor
> Labels: c++
> Attachments: AVRO-954.patch
>
>
> JsonCodec.cc has a line that reads: if (isdigit(ch) || '-')
> This doesn't do anything useful, we should change it to read: if (isdigit(ch) || ch == '-')
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-954) C++ - Typo in JsonCodec.cc
Posted by "Nebojsa Sabovic (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nebojsa Sabovic updated AVRO-954:
---------------------------------
Status: Patch Available (was: Open)
> C++ - Typo in JsonCodec.cc
> --------------------------
>
> Key: AVRO-954
> URL: https://issues.apache.org/jira/browse/AVRO-954
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.6.0
> Reporter: Nebojsa Sabovic
> Assignee: Nebojsa Sabovic
> Priority: Minor
> Labels: c++
> Attachments: AVRO-954.patch
>
>
> JsonCodec.cc has a line that reads: if (isdigit(ch) || '-')
> This doesn't do anything useful, we should change it to read: if (isdigit(ch) || ch == '-')
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira