[jira] [Commented] (FLINK-8515) update RocksDBMapState to replace deprecated remove() with delete()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340557#comment-16340557 ] 

ASF GitHub Bot commented on FLINK-8515:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5365

    [FLINK-8515] update RocksDBMapState to replace deprecated remove() with delete()

    ## What is the purpose of the change
    
    RocksDBMapState is currently using `rocksdb#remove()` which is deprecated. Should be replaced with `rocksdb#delete()`
    
    ## Brief change log
    
    update RocksDBMapState to replace deprecated remove() with delete()
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `StateBackendTestBase#testMapState()`
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-8515

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5365
    
----
commit 8cd47d5e6110e29e4c6c36aea08543048010b9aa
Author: Bowen Li <bo...@...>
Date:   2018-01-26T04:25:00Z

    [FLINK-8515] update RocksDBMapState to replace deprecated remove() with delete()

----


> update RocksDBMapState to replace deprecated remove() with delete()
> -------------------------------------------------------------------
>
>                 Key: FLINK-8515
>                 URL: https://issues.apache.org/jira/browse/FLINK-8515
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Currently in RocksDBMapState:
> {code:java}
> @Override
> 	public void remove(UK userKey) throws IOException, RocksDBException {
> 		byte[] rawKeyBytes = serializeUserKeyWithCurrentKeyAndNamespace(userKey);
> 		backend.db.remove(columnFamily, writeOptions, rawKeyBytes);
> 	}
> {code}
> remove() is actually deprecated. Should be replaced with delete()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)