[jira] [Resolved] (ORC-310) better error handling and lifecycle management for codecs

["Owen O'Malley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley resolved ORC-310.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 1.5.0

I just committed this. Thanks, Sergey!

I made the decision to make OrcCodecPool.returnCodec to always be the safe version.

I also fixed some of the comments -

WriterImpl and RecordReaderImpl are not API classes, so the comments there about removing getCompressionCodec() didn't make sense. Writer and RecordReader don't have the method.

I also moved the comment from the DefaultDataReader to DataReader where it is more visible.

If you want to see my edits I've pushed them unsquashed to https://github.com/omalley/orc/commit/167c2b095f5d9c2e7bffc6600c40d5a2ccdb8eed

> better error handling and lifecycle management for codecs
> ---------------------------------------------------------
>
>                 Key: ORC-310
>                 URL: https://issues.apache.org/jira/browse/ORC-310
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>             Fix For: 1.5.0
>
>
> When there's a failure potentially involving the codec, the codec object may be left in bad state and should not be reused (esp. given that Hadoop codecs are brittle w.r.t. how they maintain state).
> The codecs can be closed on error instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)