[jira] [Commented] (HIVE-9730) LLAP: make sure logging is never called when not needed

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334431#comment-14334431 ] 

Hive QA commented on HIVE-9730:
-------------------------------



{color:red}Overall{color}: -1 no tests executed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12700310/HIVE-9730.patch

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2852/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2852/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2852/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]]
+ export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-2852/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted 'contrib/src/test/results/clientpositive/udf_example_add.q.out'
Reverted 'contrib/src/test/results/clientpositive/udf_example_format.q.out'
Reverted 'contrib/src/test/results/clientpositive/dboutput.q.out'
Reverted 'serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java'
Reverted 'ql/src/test/results/clientnegative/limit_partition.q.out'
Reverted 'ql/src/test/results/clientpositive/spark/vector_elt.q.out'
Reverted 'ql/src/test/results/clientpositive/spark/vectorization_div0.q.out'
Reverted 'ql/src/test/results/clientpositive/spark/udf_example_add.q.out'
Reverted 'ql/src/test/results/clientpositive/spark/vector_string_concat.q.out'
Reverted 'ql/src/test/results/clientpositive/spark/temp_table.q.out'
Reverted 'ql/src/test/results/clientpositive/annotate_stats_select.q.out'
Reverted 'ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out'
Reverted 'ql/src/test/results/clientpositive/decimal_udf.q.out'
Reverted 'ql/src/test/results/clientpositive/macro.q.out'
Reverted 'ql/src/test/results/clientpositive/udf_reflect2.q.out'
Reverted 'ql/src/test/results/clientpositive/quote2.q.out'
Reverted 'ql/src/test/results/clientpositive/nonmr_fetch_threshold.q.out'
Reverted 'ql/src/test/results/clientpositive/udf_between.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/vector_elt.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/vector_string_concat.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/vectorization_div0.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/temp_table.q.out'
Reverted 'ql/src/test/results/clientpositive/tez/vectorized_date_funcs.q.out'
Reverted 'ql/src/test/results/clientpositive/literal_decimal.q.out'
Reverted 'ql/src/test/results/clientpositive/ansi_sql_arithmetic.q.out'
Reverted 'ql/src/test/results/clientpositive/literal_double.q.out'
Reverted 'ql/src/test/results/clientpositive/input_limit.q.out'
Reverted 'ql/src/test/results/clientpositive/vector_decimal_udf.q.out'
Reverted 'ql/src/test/results/clientpositive/vector_elt.q.out'
Reverted 'ql/src/test/results/clientpositive/nonmr_fetch.q.out'
Reverted 'ql/src/test/results/clientpositive/input_part8.q.out'
Reverted 'ql/src/test/results/clientpositive/vectorization_div0.q.out'
Reverted 'ql/src/test/results/clientpositive/udf_example_add.q.out'
Reverted 'ql/src/test/results/clientpositive/literal_string.q.out'
Reverted 'ql/src/test/results/clientpositive/vectorized_date_funcs.q.out'
Reverted 'ql/src/test/results/clientpositive/num_op_type_conv.q.out'
Reverted 'ql/src/test/results/clientpositive/str_to_map.q.java1.7.out'
Reverted 'ql/src/test/results/clientpositive/vector_string_concat.q.out'
Reverted 'ql/src/test/results/clientpositive/type_widening.q.out'
Reverted 'ql/src/test/results/clientpositive/udf_in_file.q.out'
Reverted 'ql/src/test/results/clientpositive/type_cast_1.q.out'
Reverted 'ql/src/test/results/clientpositive/temp_table.q.out'
Reverted 'ql/src/test/results/clientpositive/annotate_stats_limit.q.out'
Reverted 'ql/src/test/results/clientpositive/literal_ints.q.out'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/Context.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java'
++ egrep -v '^X|^Performing status on external'
++ svn status --no-ignore
++ awk '{print $2}'
+ rm -rf target datanucleus.log ant/target shims/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/scheduler/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/thirdparty itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-unit-hadoop2/target itests/hive-minikdc/target itests/hive-jmh/target itests/hive-unit/target itests/custom-serde/target itests/util/target itests/qtest-spark/target hcatalog/target hcatalog/core/target hcatalog/streaming/target hcatalog/server-extensions/target hcatalog/hcatalog-pig-adapter/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target accumulo-handler/target hwi/target common/target common/src/gen spark-client/target service/target contrib/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target
+ svn update

Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1661843.

At revision 1661843.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12700310 - PreCommit-HIVE-TRUNK-Build

> LLAP: make sure logging is never called when not needed
> -------------------------------------------------------
>
>                 Key: HIVE-9730
>                 URL: https://issues.apache.org/jira/browse/HIVE-9730
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: llap
>
>         Attachments: HIVE-9730.patch, log4j-llap.png
>
>
> log4j logging has really inefficient serialization
> !log4j-llap.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)