You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/17 03:17:45 UTC

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/
-----------------------------------------------------------

(Updated April 17, 2018, 3:17 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Partially addressed Andy's comment.


Summary (updated)
-----------------

Building gRPC support in libprocess with CMake.


Bugs: MESOS-7881
    https://issues.apache.org/jira/browse/MESOS-7881


Repository: mesos


Description
-------

This patch enables CMake to build code for gRPC support in libprocess
along with tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/CMakeLists.txt 0ce7dac5deea94623530820d173ce3ffe5b42ea4 
  3rdparty/libprocess/src/tests/CMakeLists.txt d624402bc9efb43a130a2afdf27cfc1aa69010e4 


Diff: https://reviews.apache.org/r/61118/diff/5/

Changes: https://reviews.apache.org/r/61118/diff/4-5/


Testing
-------

`sudo make check` with CMake
`cd 3rdparty/libprocess/src/tests && make libprocess-tests && ./libprocess-tests`


NOTE: Testing on Windowns is not done yet.


Thanks,

Chun-Hung Hsiao


Re: Review Request 61118: Building gRPC support in libprocess with CMake.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/#review201663
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 19, 2018, 7:31 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61118/
> -----------------------------------------------------------
> 
> (Updated April 19, 2018, 7:31 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables CMake to build code for gRPC support in libprocess
> along with tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt 1eca50a4d513b2fead111e453565edff0a3ee497 
>   3rdparty/libprocess/src/tests/CMakeLists.txt d624402bc9efb43a130a2afdf27cfc1aa69010e4 
> 
> 
> Diff: https://reviews.apache.org/r/61118/diff/7/
> 
> 
> Testing
> -------
> 
> `cmake .. -DENABLE_GRPC=1` and then `cmake --build . --target check` on Linux and Windows.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 61118: Building gRPC support in libprocess with CMake.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/
-----------------------------------------------------------

(Updated April 20, 2018, 2:31 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Enabled Windows build.


Bugs: MESOS-7881
    https://issues.apache.org/jira/browse/MESOS-7881


Repository: mesos


Description
-------

This patch enables CMake to build code for gRPC support in libprocess
along with tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/CMakeLists.txt 1eca50a4d513b2fead111e453565edff0a3ee497 
  3rdparty/libprocess/src/tests/CMakeLists.txt d624402bc9efb43a130a2afdf27cfc1aa69010e4 


Diff: https://reviews.apache.org/r/61118/diff/6/

Changes: https://reviews.apache.org/r/61118/diff/5-6/


Testing (updated)
-------

`cmake .. -DENABLE_GRPC=1` and then `cmake --build . --target check` on Linux and Windows.


Thanks,

Chun-Hung Hsiao