You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/19 00:34:19 UTC

[GitHub] [solr] epugh opened a new pull request #33: SOLR-15152: Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

epugh opened a new pull request #33:
URL: https://github.com/apache/solr/pull/33


   # Description
   
   Export tool says it uses json, but it's actually a json lines format.   It ignores anonymous and nested docs.
   
   # Solution
   
   * Tweaked the writer to properly handle anonymous and regular nested docs when exporting data.
   * Renamed the existing `json` format to `jsonl`, and introduced a proper `json` format.
   * Introduce explicit DocSinks per format, `json`, `jsonl`, and `javabin`.
   * Create new configsets for testing under `nested/anonymous` and `nested/regular` for testing.
   * added nested products example that was used in the Ref guide to the example/exampledocs/office_products.json.
   * Changed `sample_techproducts_configs` to used explicit nested docs, not anonymous nested docs, and then fixed various tests that assumed anonymous children.  This was tough!
   * Updates to the Ref Guide.
   
   Now, with the `json` format you can export and then reimport the Solr docs, including with child docs!
   
   # Tests
   
   I've added a new `TestExportToolWithNestedDocs`, and extended the existing `TestExportTool` tests.  The setup for the tests was quite different, so I didn't make them all one file.  I've updated the existing tests that 
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X] I have developed this patch against the `main` branch.
   - [ X] I have run `./gradlew check`.
   - [ X] I have added tests for my changes.
   - [ X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] epugh commented on pull request #33: SOLR-15152: Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #33:
URL: https://github.com/apache/solr/pull/33#issuecomment-802415429


   There is a lot of good commentary on https://github.com/apache/lucene-solr/pull/2356 that should be reviewed!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org