[GitHub] [hive] kgyrtkirk commented on a change in pull request #848: HIVE-22486

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #848: HIVE-22486
URL: https://github.com/apache/hive/pull/848#discussion_r349151290
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 ##########
 @@ -674,10 +677,14 @@ public TrimResult trimFields(Project project, ImmutableBitSet fieldsUsed,
     // set columnAccessInfo for ViewColumnAuthorization
     for (Ord<RexNode> ord : Ord.zip(project.getProjects())) {
       if (fieldsUsed.get(ord.i)) {
-        if (this.columnAccessInfo != null && this.viewProjectToTableSchema != null
-            && this.viewProjectToTableSchema.containsKey(project)) {
+        if (this.viewProjectToTableSchema != null && this.viewProjectToTableSchema.containsKey(project)) {
           Table tab = this.viewProjectToTableSchema.get(project);
-          this.columnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          if (this.directColumnAccessInfo != null) {
+            this.directColumnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          }
+          if (this.allColumnAccessInfo != null) {
+            this.allColumnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          }
 
 Review comment:
   this is actually duplicates the `ColumnAccessInfo` at a lot of places; wouldn't it make sense to extend `ColumnAccessInfo` internally; and enable it to "mark" columns; and add a method which is able to retrieve columns based on usage or not.
   
   right now `CAI` is a `Map< TableNameString, Set<ColumnNameString>>`; how about changing this to a `Map<TableNameString, Set<ColumnAccess>` where `ColumnAccess` would be the `ColumnNameString` and some extra info which is added here.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org