You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/01/26 06:28:14 UTC
[GitHub] incubator-rocketmq pull request #52: [ROCKETMQ-76] Expose IntegrationTestBas...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/52
[ROCKETMQ-76] Expose IntegrationTestBase to be used by other integrat\u2026
\u2026ion projects
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-76
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-76
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit aa0bad87dea93cdf223733eda34471e461dc98da
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-01-26T06:23:56Z
[ROCKETMQ-76] Expose IntegrationTestBase to be used by other integration projects
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-76
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman I have merged this PR. and I will have a review for the PR #57 later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman @lizhanhui we must keep rigorous and cautious for guys PR. So, I recommend the double interleaved close for PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
[](https://coveralls.io/builds/9850646)
Coverage increased (+0.05%) to 30.125% when pulling **aa0bad87dea93cdf223733eda34471e461dc98da on shroman:ROCKETMQ-76** into **30cabc77bd99abcf934d822d69030ddcfe38f94a on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@vongosling OK. I would merge this PR. and @shroman could you help me check the PR: https://github.com/apache/incubator-rocketmq/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
Thanks @shroman , it is very useful for other projects' integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman We'd better merge PR not the same guys. you pull, the other guy merge. @dongeforever Could you help us to merge this PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
Please @dongeforever help review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman It seems that you could merge this PR now. And according to new branching model, it is better to merge this to the 'develop' branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@vongosling Ready for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
> We'd better merge PR not the same guys.
@vongosling Any rational reasoning behind this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman since 4.1.0, we will start a new branching model, more formalized, more flexible. All PRs except those bugfix, we recommended to merge back to develop branch. This guide will publish in website sooner. So, we hope to postpone this PR merge action util 4.0.0 release :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@dongeforever Thanks! It seems there are no objections, I will merge it to `develop` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #52: [ROCKETMQ-76] Expose IntegrationTestBase to be...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@dongeforever Yes, sure. But first please address my comments for that PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #52: [ROCKETMQ-76] Expose IntegrationTestBas...
Posted by shroman <gi...@git.apache.org>.
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---