[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #10330: Add create readwrite splitting rule

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #10330:
URL: https://github.com/apache/shardingsphere/pull/10330#discussion_r632199268



##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/DistSQLVisitor.java
##########
@@ -187,6 +187,50 @@ public ASTNode visitAlterShardingBroadcastTableRules(final DistSQLStatementParse
         return result;
     }
 
+    @Override
+    public ASTNode visitCreateReadwriteSplittingRule(final DistSQLStatementParser.CreateReadwriteSplittingRuleContext ctx) {
+        Collection<ReadwriteSplittingRuleSegment> readwriteSplittingRuleSegments = new LinkedList<>();
+        for (DistSQLStatementParser.ReadwriteSplittingRuleDefinitionContext each : ctx.readwriteSplittingRuleDefinition()) {

Review comment:
       you could consider lambda syntax




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org