You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/16 13:21:18 UTC
[GitHub] [incubator-yunikorn-release] srisco opened a new pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
srisco opened a new pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79
Issue: [YUNIKORN-1078](https://issues.apache.org/jira/browse/YUNIKORN-1078)
This PR add extra parameters for the helm's chart:
- `tolerations`
- `affinity`
- `webResources.requests.cpu`
- `webResources.requests.memory`
- `webResources.limits.cpu`
- `webResources.limits.memory`
and define all the admission controller's related parameters under the `admissionController` object:
- `admissionController.image.replicaCount`
- `admissionController.serviceAccount`
- `admissionController.image.repository`
- `admissionController.image.tag`
- `admissionController.image.pullPolicy`
- `admissionController.namespaceBlacklist`
- `admissionController.resources.requests.cpu`
- `admissionController.resources.requests.memory`
- `admissionController.resources.limits.cpu`
- `admissionController.resources.limits.memory`
- `admissionController.nodeSelector`
- `admissionController.tolerations`
- `admissionController.affinity`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] srisco commented on pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
srisco commented on pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79#issuecomment-1042766451
That's a good point! Done, I think now it's more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] craigcondit commented on a change in pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
craigcondit commented on a change in pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79#discussion_r808255795
##########
File path: helm-charts/yunikorn/README.md
##########
@@ -59,33 +59,48 @@ helm install yunikorn yunikorn/yunikorn
## Configuration
The following table lists the configurable parameters of the YuniKorn chart and their default values.
-| Parameter | Description | Default |
-| --- | --- | --- |
-| `imagePullSecrets` | Docker repository secrets | ` `
-| `serviceAccount` | Service account name | `yunikorn-admin`
-| `image.repository` | Scheduler image repository | `apache/yunikorn`
-| `image.tag` | Scheduler image tag | `scheduler-latest`
-| `image.pullPolicy` | Scheduler image pull policy | `Always`
-| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn`
-| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest`
-| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always`
-| `webImage.repository` | Web app image repository | `apache/yunikorn`
-| `webImage.tag` | Web app image tag | `web-latest`
-| `webImage.pullPolicy` | Web app image pull policy | `Always`
-| `admissionControllerImage.repository` | Admission controller image repository | `apache/yunikorn`
-| `admissionControllerImage.tag` | Admission controller image tag | `admission-latest`
-| `admissionControllerImage.pullPolicy` | Admission controller image pull policy | `Always`
-| `admissionControllerNamespaceBlacklist`| Comma-separated list of namespace regexes to ignore | `^kube-system$`
-| `service.port` | Port of the scheduler service | `9080`
-| `service.portWeb` | Port of the web application service | `9889`
-| `resources.requests.cpu` | CPU resource requests | `200m`
-| `resources.requests.memory` | Memory resource requests | `1Gi`
-| `resources.limits.cpu` | CPU resource limit | `4`
-| `resources.limits.memory` | Memory resource limit | `2Gi`
-| `embedAdmissionController` | Flag for enabling/disabling the admission controller | `true`
-| `enableSchedulerPlugin` | Flag for enabling/disabling scheduler plugin mode | `false`
-| `operatorPlugins` | Scheduler operator plugins | `general`
-| `nodeSelector` | Scheduler deployment nodeSelector(s) | ` `
+| Parameter | Description | Default |
+| ----------------------------------------------- | ---------------------------------------------------- | ------------------------------- |
+| `imagePullSecrets` | Docker repository secrets | ` ` |
+| `serviceAccount` | Service account name | `yunikorn-admin` |
+| `image.repository` | Scheduler image repository | `apache/yunikorn` |
+| `image.tag` | Scheduler image tag | `scheduler-latest` |
+| `image.pullPolicy` | Scheduler image pull policy | `Always` |
+| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn` |
+| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest` |
+| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always` |
+| `webImage.repository` | Web app image repository | `apache/yunikorn` |
+| `webImage.tag` | Web app image tag | `web-latest` |
+| `webImage.pullPolicy` | Web app image pull policy | `Always` |
+| `admissionController.image.replicaCount` | Admission controller image repository | `1` |
Review comment:
Can we make this just `admissionController.replicaCount` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] srisco commented on a change in pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
srisco commented on a change in pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79#discussion_r808273298
##########
File path: helm-charts/yunikorn/README.md
##########
@@ -59,33 +59,48 @@ helm install yunikorn yunikorn/yunikorn
## Configuration
The following table lists the configurable parameters of the YuniKorn chart and their default values.
-| Parameter | Description | Default |
-| --- | --- | --- |
-| `imagePullSecrets` | Docker repository secrets | ` `
-| `serviceAccount` | Service account name | `yunikorn-admin`
-| `image.repository` | Scheduler image repository | `apache/yunikorn`
-| `image.tag` | Scheduler image tag | `scheduler-latest`
-| `image.pullPolicy` | Scheduler image pull policy | `Always`
-| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn`
-| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest`
-| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always`
-| `webImage.repository` | Web app image repository | `apache/yunikorn`
-| `webImage.tag` | Web app image tag | `web-latest`
-| `webImage.pullPolicy` | Web app image pull policy | `Always`
-| `admissionControllerImage.repository` | Admission controller image repository | `apache/yunikorn`
-| `admissionControllerImage.tag` | Admission controller image tag | `admission-latest`
-| `admissionControllerImage.pullPolicy` | Admission controller image pull policy | `Always`
-| `admissionControllerNamespaceBlacklist`| Comma-separated list of namespace regexes to ignore | `^kube-system$`
-| `service.port` | Port of the scheduler service | `9080`
-| `service.portWeb` | Port of the web application service | `9889`
-| `resources.requests.cpu` | CPU resource requests | `200m`
-| `resources.requests.memory` | Memory resource requests | `1Gi`
-| `resources.limits.cpu` | CPU resource limit | `4`
-| `resources.limits.memory` | Memory resource limit | `2Gi`
-| `embedAdmissionController` | Flag for enabling/disabling the admission controller | `true`
-| `enableSchedulerPlugin` | Flag for enabling/disabling scheduler plugin mode | `false`
-| `operatorPlugins` | Scheduler operator plugins | `general`
-| `nodeSelector` | Scheduler deployment nodeSelector(s) | ` `
+| Parameter | Description | Default |
+| ----------------------------------------------- | ---------------------------------------------------- | ------------------------------- |
+| `imagePullSecrets` | Docker repository secrets | ` ` |
+| `serviceAccount` | Service account name | `yunikorn-admin` |
+| `image.repository` | Scheduler image repository | `apache/yunikorn` |
+| `image.tag` | Scheduler image tag | `scheduler-latest` |
+| `image.pullPolicy` | Scheduler image pull policy | `Always` |
+| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn` |
+| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest` |
+| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always` |
+| `webImage.repository` | Web app image repository | `apache/yunikorn` |
+| `webImage.tag` | Web app image tag | `web-latest` |
+| `webImage.pullPolicy` | Web app image pull policy | `Always` |
+| `admissionController.image.replicaCount` | Admission controller image repository | `1` |
Review comment:
Sorry, I messed it up when copying in the documentation.
BTW I have added a line for the `replicaCount` of the scheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] wilfred-s commented on a change in pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79#discussion_r808491341
##########
File path: helm-charts/yunikorn/README.md
##########
@@ -59,33 +59,49 @@ helm install yunikorn yunikorn/yunikorn
## Configuration
The following table lists the configurable parameters of the YuniKorn chart and their default values.
-| Parameter | Description | Default |
-| --- | --- | --- |
-| `imagePullSecrets` | Docker repository secrets | ` `
-| `serviceAccount` | Service account name | `yunikorn-admin`
-| `image.repository` | Scheduler image repository | `apache/yunikorn`
-| `image.tag` | Scheduler image tag | `scheduler-latest`
-| `image.pullPolicy` | Scheduler image pull policy | `Always`
-| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn`
-| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest`
-| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always`
-| `webImage.repository` | Web app image repository | `apache/yunikorn`
-| `webImage.tag` | Web app image tag | `web-latest`
-| `webImage.pullPolicy` | Web app image pull policy | `Always`
-| `admissionControllerImage.repository` | Admission controller image repository | `apache/yunikorn`
-| `admissionControllerImage.tag` | Admission controller image tag | `admission-latest`
-| `admissionControllerImage.pullPolicy` | Admission controller image pull policy | `Always`
-| `admissionControllerNamespaceBlacklist`| Comma-separated list of namespace regexes to ignore | `^kube-system$`
-| `service.port` | Port of the scheduler service | `9080`
-| `service.portWeb` | Port of the web application service | `9889`
-| `resources.requests.cpu` | CPU resource requests | `200m`
-| `resources.requests.memory` | Memory resource requests | `1Gi`
-| `resources.limits.cpu` | CPU resource limit | `4`
-| `resources.limits.memory` | Memory resource limit | `2Gi`
-| `embedAdmissionController` | Flag for enabling/disabling the admission controller | `true`
-| `enableSchedulerPlugin` | Flag for enabling/disabling scheduler plugin mode | `false`
-| `operatorPlugins` | Scheduler operator plugins | `general`
-| `nodeSelector` | Scheduler deployment nodeSelector(s) | ` `
+| Parameter | Description | Default |
+| ----------------------------------------------- | ---------------------------------------------------- | ------------------------------- |
+| `imagePullSecrets` | Docker repository secrets | ` ` |
+| `serviceAccount` | Service account name | `yunikorn-admin` |
+| `replicaCount` | Scheduler replicas to be deployed | `1` |
+| `image.repository` | Scheduler image repository | `apache/yunikorn` |
+| `image.tag` | Scheduler image tag | `scheduler-latest` |
+| `image.pullPolicy` | Scheduler image pull policy | `Always` |
+| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn` |
+| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest` |
+| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always` |
+| `webImage.repository` | Web app image repository | `apache/yunikorn` |
+| `webImage.tag` | Web app image tag | `web-latest` |
+| `webImage.pullPolicy` | Web app image pull policy | `Always` |
Review comment:
Now that we are updating and changing we should use a consistent naming convention here and make this `web.image.pullPolicy` etc Inline with the `admissionController`
##########
File path: helm-charts/yunikorn/README.md
##########
@@ -59,33 +59,49 @@ helm install yunikorn yunikorn/yunikorn
## Configuration
The following table lists the configurable parameters of the YuniKorn chart and their default values.
-| Parameter | Description | Default |
-| --- | --- | --- |
-| `imagePullSecrets` | Docker repository secrets | ` `
-| `serviceAccount` | Service account name | `yunikorn-admin`
-| `image.repository` | Scheduler image repository | `apache/yunikorn`
-| `image.tag` | Scheduler image tag | `scheduler-latest`
-| `image.pullPolicy` | Scheduler image pull policy | `Always`
-| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn`
-| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest`
-| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always`
-| `webImage.repository` | Web app image repository | `apache/yunikorn`
-| `webImage.tag` | Web app image tag | `web-latest`
-| `webImage.pullPolicy` | Web app image pull policy | `Always`
-| `admissionControllerImage.repository` | Admission controller image repository | `apache/yunikorn`
-| `admissionControllerImage.tag` | Admission controller image tag | `admission-latest`
-| `admissionControllerImage.pullPolicy` | Admission controller image pull policy | `Always`
-| `admissionControllerNamespaceBlacklist`| Comma-separated list of namespace regexes to ignore | `^kube-system$`
-| `service.port` | Port of the scheduler service | `9080`
-| `service.portWeb` | Port of the web application service | `9889`
-| `resources.requests.cpu` | CPU resource requests | `200m`
-| `resources.requests.memory` | Memory resource requests | `1Gi`
-| `resources.limits.cpu` | CPU resource limit | `4`
-| `resources.limits.memory` | Memory resource limit | `2Gi`
-| `embedAdmissionController` | Flag for enabling/disabling the admission controller | `true`
-| `enableSchedulerPlugin` | Flag for enabling/disabling scheduler plugin mode | `false`
-| `operatorPlugins` | Scheduler operator plugins | `general`
-| `nodeSelector` | Scheduler deployment nodeSelector(s) | ` `
+| Parameter | Description | Default |
+| ----------------------------------------------- | ---------------------------------------------------- | ------------------------------- |
+| `imagePullSecrets` | Docker repository secrets | ` ` |
+| `serviceAccount` | Service account name | `yunikorn-admin` |
+| `replicaCount` | Scheduler replicas to be deployed | `1` |
+| `image.repository` | Scheduler image repository | `apache/yunikorn` |
+| `image.tag` | Scheduler image tag | `scheduler-latest` |
+| `image.pullPolicy` | Scheduler image pull policy | `Always` |
+| `pluginImage.repository` | Scheduler plugin image repository | `apache/yunikorn` |
+| `pluginImage.tag` | Scheduler plugin image tag | `scheduler-plugin-latest` |
+| `pluginImage.pullPolicy` | Scheduler plugin image pull policy | `Always` |
+| `webImage.repository` | Web app image repository | `apache/yunikorn` |
+| `webImage.tag` | Web app image tag | `web-latest` |
+| `webImage.pullPolicy` | Web app image pull policy | `Always` |
+| `admissionController.replicaCount` | Admission controller replicas to be deployed | `1` |
+| `admissionController.serviceAccount` | Admission controller service account name | `yunikorn-admission-controller` |
+| `admissionController.image.repository` | Admission controller image repository | `apache/yunikorn` |
+| `admissionController.image.tag` | Admission controller image tag | `admission-latest` |
+| `admissionController.image.pullPolicy` | Admission controller image pull policy | `Always` |
+| `admissionController.namespaceBlacklist` | Comma-separated list of namespace regexes to ignore | `^kube-system$` |
+| `admissionController.resources.requests.cpu` | Admission controller CPU resource requests | `100m` |
+| `admissionController.resources.requests.memory` | Admission controller memory resource requests | `500Mi` |
+| `admissionController.resources.limits.cpu` | Admission controller CPU resource limit | `500m` |
+| `admissionController.resources.limits.memory` | Admission controller memory resource limit | `500Mi` |
+| `admissionController.nodeSelector` | Admission controller deployment nodeSelector(s) | `{}` |
+| `admissionController.tolerations` | Admission controller deployment tolerations | `[]` |
+| `admissionController.affinity` | Admission controller deployment affinity | `{}` |
+| `service.port` | Port of the scheduler service | `9080` |
+| `service.portWeb` | Port of the web application service | `9889` |
+| `resources.requests.cpu` | CPU resource requests | `200m` |
+| `resources.requests.memory` | Memory resource requests | `1Gi` |
+| `resources.limits.cpu` | CPU resource limit | `4` |
+| `resources.limits.memory` | Memory resource limit | `2Gi` |
+| `webResources.requests.cpu` | Web app CPU resource requests | `100m` |
+| `webResources.requests.memory` | Web app memory resource requests | `100Mi` |
+| `webResources.limits.cpu` | Web app CPU resource limit | `200m` |
+| `webResources.limits.memory` | Web app memory resource limit | `500Mi` |
Review comment:
Same here as for the `webImage` comment we should be consistent and use `web.resources`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] craigcondit commented on pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79#issuecomment-1041912445
Looks good, though I'd like to get @wilfred-s to take a look as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] craigcondit closed pull request #79: [YUNIKORN-1078] Add more parameters in helm chart
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #79:
URL: https://github.com/apache/incubator-yunikorn-release/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org