[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3505: update success about wait writeSet for Writable result

[GitBox <gi...@apache.org>]

StevenLuMT commented on code in PR #3505:
URL: https://github.com/apache/bookkeeper/pull/3505#discussion_r980687850


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -1262,7 +1262,7 @@ protected boolean waitForWritable(DistributionSchedule.WriteSet writeSet,
             final int maxBackoff = 4;
             final long deadline = startTime + TimeUnit.MILLISECONDS.toNanos(durationMs);
 
-            while (!isWriteSetWritable(writeSet, allowedNonWritableCount)) {
+            while (!(success = isWriteSetWritable(writeSet, allowedNonWritableCount))) {

Review Comment:
   I think success can be named writableResult,like the code:
   `while (!(writableResult = isWriteSetWritable(writeSet, allowedNonWritableCount))) {`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org