You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/08/14 09:02:27 UTC
[I] sync_validate: catch-up counting assumes commit action (breaks MOR/clustered targets); JDBC failure masked by NPE [hudi]
voonhous opened a new issue, #19635:
URL: https://github.com/apache/hudi/issues/19635
**Describe the problem**
Two bugs in `ValidateHoodieSyncProcedure` (`sync_validate`):
1. `countNewRecords` reconstructs each catch-up instant hardcoding `HoodieTimeline.COMMIT_ACTION`, but the catch-up list comes from `getCommitsTimeline` (includes deltacommits) and is resolved against `getCommitAndReplaceTimeline`. Any MOR target, or a target with a `replacecommit` (clustering / insert overwrite) in the catch-up range, fails to read the instant file. Present since #6200.
2. In the JDBC count path, `finally { conn.close() }` runs with `conn == null` when `DriverManager.getConnection` fails, so the real `SQLException` is masked by an NPE. The sibling overload in the same file guards with `if (conn != null)` -- clearly an oversight.
**Suggested fix**
Carry the actual `HoodieInstant` from `commitsToCatchup` instead of synthesizing a COMMIT instant; null-guard the `finally`. Cheap regression tests: a MOR variant of the catch-up test in `TestValidateHoodieSyncProcedure` (added in #19161), and `mode => 'complete'` with an unreachable JDBC URL asserting a connection error rather than an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] sync_validate: catch-up counting assumes commit action (breaks MOR/clustered targets); JDBC failure masked by NPE [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on issue #19635:
URL: https://github.com/apache/hudi/issues/19635#issuecomment-6509993738
@prathik-onehouse could you take a look at this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org