You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by Darin726 <gi...@git.apache.org> on 2018/06/28 03:47:22 UTC
[GitHub] incubator-weex pull request #1299: [WEEX-483][Android] get options from argu...
GitHub user Darin726 opened a pull request:
https://github.com/apache/incubator-weex/pull/1299
[WEEX-483][Android] get options from arguments in callNativeModule
https://issues.apache.org/jira/browse/WEEX-483
[WEEX-483][Android] get options from arguments in callNativeModule
options has been put in the arguments, So we should get options from arguments
Bug: WEEX-483
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Darin726/incubator-weex master-0628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1299
----
commit 09beae0ec7bfd8e23be636a94f7c84dad13d669f
Author: Darin <dy...@...>
Date: 2018-06-21T04:54:45Z
[WEEX-483][Android] get options from arguments in callNativeModule
options has been put in the arguments, So we should get options from arguments
Bug: WEEX-483
----
---
[GitHub] incubator-weex issue #1299: [WEEX-483][Android] get options from arguments i...
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian commented on the issue:
https://github.com/apache/incubator-weex/pull/1299
you should handle the arguments in your javascript code, not in weex sdk
---
[GitHub] incubator-weex issue #1299: [WEEX-483][Android] get options from arguments i...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1299
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---