You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/12 11:57:36 UTC
[GitHub] [shardingsphere] pjfanning edited a comment on pull request #15260: [issue-15259] upgrade snakeyaml due to cve
pjfanning edited a comment on pull request #15260:
URL: https://github.com/apache/shardingsphere/pull/15260#issuecomment-1037178060
what I don't understand is mockYamlExecuteProcessContext and YamlEngine.marshal
For YamlExecuteProcessContext it returns:
```
unitStatuses: !!set
? status: EXECUTE_STATUS_DONE
unitID: '159917166'
: null
```
Wouldn't yaml like this be a better representation (generated using jackson-dataformat-yaml)?:
```
executionID: null
schemaName: null
username: null
hostname: null
sql: null
unitStatuses:
- unitID: "159917166"
status: "EXECUTE_STATUS_DONE"
startTimeMillis: null
```
The custom yaml code in shardingsphere confuses me - I just think it would be easier to use jackson-dataformat-yaml instead. jackson-dataformat-yaml uses snakeyaml but recent versions of jackson-dataformat-yaml use up to date versions of snakeyaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org