[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10909: fix: several disabled pylint rules in models/helpers.py

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #10909:
URL: https://github.com/apache/incubator-superset/pull/10909#discussion_r490936265



##########
File path: superset/models/helpers.py
##########
@@ -424,7 +425,10 @@ class ExtraJSONMixin:
     def extra(self) -> Dict[str, Any]:
         try:
             return json.loads(self.extra_json)
-        except Exception:  # pylint: disable=broad-except
+        except (TypeError, JSONDecodeError) as exc:
+            logger.error(
+                "Unable to load an extra json: %r. Leaving empty.", exc, exc_info=True

Review comment:
       Can `exc` or `exc_info` log data from `self.extra_json` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org