You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/03/30 00:24:27 UTC

Review Request 66372: ATLAS-2524: fix Hive hook for incorrect handling of 'alter view as' operation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66372/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Ramesh Mani, and Sarath Subramanian.


Bugs: ATLAS-2425
    https://issues.apache.org/jira/browse/ATLAS-2425


Repository: atlas


Description
-------

removed output entities for create/alter operations from 'known' entity cache, so that complete details of the updated entities will be incldued in notificaitons


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 9105ebe66 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java 23db807f2 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 0c38bb371 


Diff: https://reviews.apache.org/r/66372/diff/1/


Testing
-------

Verfied that the metadata of the altered view is seen correctly in Atlas.


Thanks,

Madhan Neethiraj


Re: Review Request 66372: ATLAS-2524: fix Hive hook for incorrect handling of 'alter view as' operation

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66372/#review200247
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On March 30, 2018, 12:24 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66372/
> -----------------------------------------------------------
> 
> (Updated March 30, 2018, 12:24 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Ramesh Mani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2524
>     https://issues.apache.org/jira/browse/ATLAS-2524
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> removed output entities for create/alter operations from 'known' entity cache, so that complete details of the updated entities will be incldued in notificaitons
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 9105ebe66 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java 23db807f2 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 0c38bb371 
> 
> 
> Diff: https://reviews.apache.org/r/66372/diff/1/
> 
> 
> Testing
> -------
> 
> Verfied that the metadata of the altered view is seen correctly in Atlas.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 66372: ATLAS-2524: fix Hive hook for incorrect handling of 'alter view as' operation

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66372/#review200250
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On March 30, 2018, 12:24 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66372/
> -----------------------------------------------------------
> 
> (Updated March 30, 2018, 12:24 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Ramesh Mani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2524
>     https://issues.apache.org/jira/browse/ATLAS-2524
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> removed output entities for create/alter operations from 'known' entity cache, so that complete details of the updated entities will be incldued in notificaitons
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java 9105ebe66 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java 23db807f2 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 0c38bb371 
> 
> 
> Diff: https://reviews.apache.org/r/66372/diff/1/
> 
> 
> Testing
> -------
> 
> Verfied that the metadata of the altered view is seen correctly in Atlas.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>