[GitHub] [incubator-brpc] jamesge commented on a change in pull request #733: Add a gflag to enable tcp keepalive

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #733: Add a gflag to enable tcp keepalive
URL: https://github.com/apache/incubator-brpc/pull/733#discussion_r275720021
 
 

 ##########
 File path: src/brpc/socket.cpp
 ##########
 @@ -70,6 +70,10 @@ DEFINE_bool(log_idle_connection_close, false,
             "Print log when an idle connection is closed");
 BRPC_VALIDATE_GFLAG(log_idle_connection_close, PassValidate);
 
+DEFINE_int32(socket_server_tcp_keepalive, true, 
 
 Review comment:
   This name is inconsistent with the impl. which works for client as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org