You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/03/13 19:03:33 UTC
[jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)
RiakCS using the S3 interface occasionally surfaces these status
codes.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds s3-504-retry
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/317
-- Commit Summary --
* Retry on S3 HTTP 504 Gateway Timeout status codes
-- File Changes --
M apis/sts/src/main/java/org/jclouds/aws/handlers/AWSServerErrorRetryHandler.java (6)
M apis/sts/src/test/java/org/jclouds/aws/handlers/AWSServerErrorRetryHandlerTest.java (15)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/317.patch
https://github.com/jclouds/jclouds/pull/317.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #910](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/910/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37572005
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #661](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/661/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37682294
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by Andrew Gaul <no...@github.com>.
Closed #317.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by Andrew Phillips <no...@github.com>.
> @@ -112,4 +113,21 @@ public Integer answer() throws Throwable {
>
> }
>
> + @Test
> + public void test504DoesRetry() {
> + AWSUtils utils = createMock(AWSUtils.class);
> + HttpCommand command = createMock(HttpCommand.class);
> + expect(command.getFailureCount()).andReturn(1).anyTimes();
> + expect(command.incrementFailureCount()).andReturn(1);
> + expect(command.isReplayable()).andReturn(true);
> +
> + replay(utils, command);
> +
> + AWSServerErrorRetryHandler retry = new AWSServerErrorRetryHandler(utils,
> + ImmutableSet.<String> of());
> +
> + assertTrue(retry.shouldRetryRequest(command, HttpResponse.builder().statusCode(504).build()));
I guess this returns true because the `super.shouldRetryRequest` call will return true?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317/files#r10735049
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master and 1.7.x. Thanks @tdmanv for the feedback!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37685162
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by Andrew Phillips <no...@github.com>.
If I understand correctly, the change basically was "delegate decision to retry to parent class on 504"? If I'm getting that right, +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-38011814
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1129](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1129/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37574698
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #659](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/659/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37573917
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by Shri Javadekar <no...@github.com>.
Looks good to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37567286
Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes
(#317)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1131](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1131/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/317#issuecomment-37682720