[GitHub] [beam] mbenenso commented on pull request #15434: [BEAM-12824] Beam Connector for Reading Data from Delta Lake.

[GitBox <gi...@apache.org>]

mbenenso commented on pull request #15434:
URL: https://github.com/apache/beam/pull/15434#issuecomment-987237855


   Hi, Pablo
   
   Yes, this is ok with me.
   
   One thing we may consider is to convert pom.xml to build.gradle.
   Both java & scala should be compiled, so it is not a simple copy/paste
   operation.
   
   But even without this conversion, I think it is ok to merge, because
   customers could compile the DeltaLake connector using maven.
   
   On Mon, Dec 6, 2021 at 7:35 AM Pablo ***@***.***> wrote:
   
   > I'm quite sorry. @mbenenso <https://github.com/mbenenso> I think we can
   > move forward with the PR as-is, and leave a couple issues to track down
   > later. How does that sound?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/15434#issuecomment-986889947>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AVJGAQFL6AYEPLCXPCXOULDUPTJ43ANCNFSM5DFKT72A>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   
   
   -- 
   Thanks
   
   ------------------------------
   Michael Benenson
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org