You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (JIRA)" <ji...@apache.org> on 2011/03/01 01:29:36 UTC
[jira] Created: (OODT-149) XmlRpcStructFactory when creating XmlRpc
Job converts a Job's JobId to empty String but doesn't convert it back to
null
XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
-----------------------------------------------------------------------------------------------------------------------
Key: OODT-149
URL: https://issues.apache.org/jira/browse/OODT-149
Project: OODT
Issue Type: Bug
Components: resource manager
Affects Versions: 0.2
Environment: none
Reporter: Brian Foster
Assignee: Brian Foster
Priority: Minor
Fix For: 0.3
either:
1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000690#comment-13000690 ]
Chris A. Mattmann commented on OODT-149:
----------------------------------------
bq. null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html)
And? It's also the # cause of *Null*PointerExceptions. As opposed to "".
bq. this makes it is clear at any point in the code that the JobId has not been set yet
Sorry I don't buy that. It's no more clear than setting it to "" as the Resource Manager to date has done.
bq. also the default value for JobId in Job class is null
So? There's a big difference between default values set in a class and ways to serialize the attribute over the wire.
bq. if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null
Huh? No it wouldn't what code? I believe that we can check for null && if !null then check for .equals(""). Also hypotheticals don't solve anything. Until someone implements another protocol layer for the Resource Manager, then we're fine the way it already is.
bq. the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
Right, which is the critical SerDe right now b/c it's the only one that exists.
Right,
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.3
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-149:
-----------------------------------
Fix Version/s: (was: 0.3)
0.4
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Chris A. Mattmann (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-149:
-----------------------------------
Fix Version/s: (was: 0.4)
0.5
- push to 0.5
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.5
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (OODT-149) XmlRpcStructFactory when
creating XmlRpc Job converts a Job's JobId to empty String but doesn't
convert it back to null
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000690#comment-13000690 ]
Chris A. Mattmann edited comment on OODT-149 at 3/1/11 3:49 AM:
----------------------------------------------------------------
bq. null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html)
And? It's also the #1 cause of *Null*PointerExceptions. As opposed to "".
bq. this makes it is clear at any point in the code that the JobId has not been set yet
Sorry I don't buy that. It's no more clear than setting it to "" as the Resource Manager to date has done.
bq. also the default value for JobId in Job class is null
So? There's a big difference between default values set in a class and ways to serialize the attribute over the wire.
bq. if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null
Huh? No it wouldn't what code? I believe that we can check for null && if !null then check for .equals(""). Also hypotheticals don't solve anything. Until someone implements another protocol layer for the Resource Manager, then we're fine the way it already is.
bq. the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
Right, which is the critical SerDe right now b/c it's the only one that exists.
was (Author: chrismattmann):
bq. null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html)
And? It's also the #1 cause of *Null*PointerExceptions. As opposed to "".
bq. this makes it is clear at any point in the code that the JobId has not been set yet
Sorry I don't buy that. It's no more clear than setting it to "" as the Resource Manager to date has done.
bq. also the default value for JobId in Job class is null
So? There's a big difference between default values set in a class and ways to serialize the attribute over the wire.
bq. if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null
Huh? No it wouldn't what code? I believe that we can check for null && if !null then check for .equals(""). Also hypotheticals don't solve anything. Until someone implements another protocol layer for the Resource Manager, then we're fine the way it already is.
bq. the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
Right, which is the critical SerDe right now b/c it's the only one that exists.
Right,
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.3
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000669#comment-13000669 ]
Chris A. Mattmann commented on OODT-149:
----------------------------------------
Hey Brian why is this a problem?
# We can test for ""
# nulls don't really play nicely with code (they lead to hard to find NPEs). Why ship null around or even recreate null when we can create "" and test for it?
# We'll likely never have the case where we have a job id of ""
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.3
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (OODT-149) XmlRpcStructFactory when
creating XmlRpc Job converts a Job's JobId to empty String but doesn't
convert it back to null
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000690#comment-13000690 ]
Chris A. Mattmann edited comment on OODT-149 at 3/1/11 3:48 AM:
----------------------------------------------------------------
bq. null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html)
And? It's also the #1 cause of *Null*PointerExceptions. As opposed to "".
bq. this makes it is clear at any point in the code that the JobId has not been set yet
Sorry I don't buy that. It's no more clear than setting it to "" as the Resource Manager to date has done.
bq. also the default value for JobId in Job class is null
So? There's a big difference between default values set in a class and ways to serialize the attribute over the wire.
bq. if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null
Huh? No it wouldn't what code? I believe that we can check for null && if !null then check for .equals(""). Also hypotheticals don't solve anything. Until someone implements another protocol layer for the Resource Manager, then we're fine the way it already is.
bq. the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
Right, which is the critical SerDe right now b/c it's the only one that exists.
Right,
was (Author: chrismattmann):
bq. null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html)
And? It's also the # cause of *Null*PointerExceptions. As opposed to "".
bq. this makes it is clear at any point in the code that the JobId has not been set yet
Sorry I don't buy that. It's no more clear than setting it to "" as the Resource Manager to date has done.
bq. also the default value for JobId in Job class is null
So? There's a big difference between default values set in a class and ways to serialize the attribute over the wire.
bq. if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null
Huh? No it wouldn't what code? I believe that we can check for null && if !null then check for .equals(""). Also hypotheticals don't solve anything. Until someone implements another protocol layer for the Resource Manager, then we're fine the way it already is.
bq. the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
Right, which is the critical SerDe right now b/c it's the only one that exists.
Right,
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.3
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Chris A. Mattmann (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-149:
-----------------------------------
- push out to 0.5
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.5
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OODT-149) XmlRpcStructFactory when creating
XmlRpc Job converts a Job's JobId to empty String but doesn't convert it
back to null
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000681#comment-13000681 ]
Brian Foster commented on OODT-149:
-----------------------------------
null is the default initialization value for a String in Java (http://download.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html) . . . this makes it is clear at any point in the code that the JobId has not been set yet . . . also the default value for JobId in Job class is null . . . if the Resource Manager code where to ever be wrapped and not use the XML-RPC service, then code would throw null pointer exceptions since all the code would be assuming JobId to be "" and never be null . . . the only code enforcing JobId equals "" when not set is in the XML-RPC serialization utils.
> XmlRpcStructFactory when creating XmlRpc Job converts a Job's JobId to empty String but doesn't convert it back to null
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: OODT-149
> URL: https://issues.apache.org/jira/browse/OODT-149
> Project: OODT
> Issue Type: Bug
> Components: resource manager
> Affects Versions: 0.2
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.3
>
>
> either:
> 1) change it such that when XML-RPC Job is converted back to a Job, its JobId is set to null if it is empty string
> 2) if null, set JobId to String "null", then convert back to null if JobId is "null"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira